1029809 - Support for GNU/Hurd in Firefox 30+

Status: NEW

(Core :: General, defect)

Description

[Richard Braun]

Attachment: 0001-Hurd-support.patch

User Agent: Mozilla/5.0 (X11; GNU i686-AT386; rv:30.0) Gecko/20100101 Firefox/30.0 Iceweasel/30.0 (Beta/Release)
Build ID: 20140621171126

Steps to reproduce:

Here is a patch that makes Firefox 30 build on the Hurd. It was created against the Debian Iceweasel unstable package. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729340.

Thanks.

Comment 1

[congzhang]

Hi, as firefox was the mainly workable and wonderful browser for hurd user, that's very important to be buildable first, current usable version is 17 which was too old.

Can anyone give more detail why the patches can't be apply or whether is suitable, if you can point which part block it to be apply, we can fix it.

Thanks。

Comment 2

[Richard Braun]

Any news ?

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8445465 [details] [diff] [review]
0001-Hurd-support.patch

Review of attachment 8445465 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry it took so long :(

Could you refresh against current mozilla-central, many of the files you are patching don't exist anymore. Also, I wonder if it wouldn't be less changes to pretend hurd is OS_LINUX instead of adding OS_HURD (because, let's face it, it's more likely that a new #ifdef OS_LINUX shows up and works on hurd than that new #ifdef coming with the right OS_HURD branch when imported).

Comment 4

[Richard Braun]

Yes, I'm going to try that.

Comment 5

[Richard Braun]

Well, it turns out adding OS_HURD is actually much simpler. I've refreshed the patch for Firefox 36 (actually Iceweasel 36.0-2, but there is only one trivial rejection on gecko-dev). And I'm using the result right now to write this comment.

Concerning maintenance, I'll regularly check Hurd support, it's quite reasonable for a patch this size, and it doesn't matter much if people don't think about an OS_HURD #ifdef since they're normally used for features that we don't provide such as sound or video acceleration.

Comment 6

[Richard Braun]

Attachment: 0001-Hurd-support.patch for Firefox 36

Comment 7

[Richard Braun]

Ping before it gets rotten again.

Comment 8

[James Clarke]

Attachment: Hurd support for Firefox 45

Updated for Firefox 45

Comment 9

[James Clarke]

Ping; just updated this for Firefox 45, and it would be good to get this integrated. The changes really don't affect other platforms at all, as it is solely a case of putting the relevant #define's and #ifdef's in for OS_HURD.

Comment 10

[Nathan Froyd [:froydnj]]

Comment on attachment 8744021 [details] [diff] [review]
Hurd support for Firefox 45

Review of attachment 8744021 [details] [diff] [review]:
-----------------------------------------------------------------

When you post a patch, you should flag someone for review.  Since Mike has looked at this previous, tagging him again.

Comment 11

[James Clarke]

Comment on attachment 8744021 [details] [diff] [review]
Hurd support for Firefox 45

Review of attachment 8744021 [details] [diff] [review]:
-----------------------------------------------------------------

I realise I've been inconsistent with the #ifdef ordering, but that can trivially be fixed, and I don't think there's much point attaching an updated version just to change that, at least not unless it's been reviewed and that's all that needs changing.

Comment 12

[James Clarke]

Hi, has there been any progress on this?