1029834 - Make contextmenu/menu telemetry more consistent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

* Add telemetry for paste and copyurl should always send an ACTION

* site_settings and subscribe should use the VERSION.SDK_INT check since they are on the Page menu for newer OS

Comment 1

[Chenxia Liu [:liuche]]

mfinkle, you mentioned in bug 1007130 that you wanted to switch over the pasteandgo item to ACTION, but I think that gives us less information than LOAD_URL. If we do that, I would be inclined to update the TelemetryContract action to loadurl.2 (because we're removing pasteandgo from loadurl.1, and adding it to action.1).

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Patch: Add some missing telemetry

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Chenxia Liu [:liuche] from comment #1)
> mfinkle, you mentioned in bug 1007130 that you wanted to switch over the
> pasteandgo item to ACTION, but I think that gives us less information than
> LOAD_URL. If we do that, I would be inclined to update the TelemetryContract
> action to loadurl.2 (because we're removing pasteandgo from loadurl.1, and
> adding it to action.1).

I would definitely keep the LOAD_URL event, but also add an ACTION too. We already have more than a few places where two or more telemetry probes are fired for the same situation.

Comment 4

[Chenxia Liu [:liuche]]

Attachment: Patch: Add missing telemetry v2

I also added the telemetry for the action bar. This uses the titles of the action bar buttons, which are not really in the same format as our other probes. Have another patch that adds the probes in JS, which is less clean because you have to do it for ever item, but the extras are consistent with what we've been using.

Comment 5

[Chenxia Liu [:liuche]]

Attachment: Optional part 2: Add actionbar probes in JS, not Java

This patch makes it so we use extras like:
- "search" instead of "Google Search"
- "select_all" instead of "Select All"
- "call" instead of "Call"
& etc.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8446040 [details] [diff] [review]
Optional part 2: Add actionbar probes in JS, not Java

I like this patch too.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8446030 [details] [diff] [review]
Patch: Add missing telemetry v2

Let's do the optional part too.

Comment 8

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/b7a8029273f5

Comment 9

[Chenxia Liu [:liuche]]

Attachment: Patch: Single patch for actionbar telemetry + missing telemetry

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Incomplete Telemetry from bug 1004889
User impact if declined: No telemetry on some menu items for Aurora and beta users
Testing completed (on m-c, etc.): local, baking on nightly
Risk to taking this patch (and alternatives if risky): very low, adding telemetry probes
String or IDL/UUID changes made by this patch: none

Carrying over r+ for combined patch.

Comment 10

[Chenxia Liu [:liuche]]

Bah, wrong changeset link.

https://hg.mozilla.org/integration/fx-team/rev/9ef3bd020eed

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ef3bd020eed

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/990b3688423b
https://hg.mozilla.org/releases/mozilla-beta/rev/f647dbf6509c