Closed
Bug 1029870
Opened 11 years ago
Closed 11 years ago
Update tools/update-packaging/make_incremental_update.sh to allow passing Product Version and Channel ID
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ffledgling, Assigned: ffledgling)
References
Details
Attachments
(1 file)
1.15 KB,
patch
|
nthomas
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
Currently there is no way to pass the ChannelID and ProductVersion to the MAR binary at run time.
See: http://hg.mozilla.org/mozilla-central/file/tip/tools/update-packaging/make_incremental_update.sh#l278
Adding provisions in the script to check $MOZ_CHANNEL_ID and $MOZ_PRODUCT_VERSION environment variables to allow for this at run time.
Assignee | ||
Comment 1•11 years ago
|
||
Adding patch.
Note: The strange order of appending flags to the `$mar_command` is because the -c <output_file> flag needs to be at the end, else everything after the -c flag is treated as a filename
Probably because of the way args are handled here: http://hg.mozilla.org/mozilla-central/file/a19e0434ea52/modules/libmar/tool/mar.c#l155
Comment 2•11 years ago
|
||
Comment on attachment 8445637 [details] [diff] [review]
Bug-1029870.patch
Tested fine on our win32/mac/linux64 systems. If this works in the service too we can go ahead and land it.
Attachment #8445637 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 3•11 years ago
|
||
How do we make sure it works in service as well?
Comment 4•11 years ago
|
||
Comment on attachment 8445637 [details] [diff] [review]
Bug-1029870.patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa5aac520f6
Expect the sheriffs to merge this to m-c within a day, closing the bug when they do.
Attachment #8445637 -
Flags: checked-in+
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•