Update tools/update-packaging/make_incremental_update.sh to allow passing Product Version and Channel ID

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
16 days ago

People

(Reporter: ffledgling, Assigned: ffledgling)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently there is no way to pass the ChannelID and ProductVersion to the MAR binary at run time.
See: http://hg.mozilla.org/mozilla-central/file/tip/tools/update-packaging/make_incremental_update.sh#l278

Adding provisions in the script to check $MOZ_CHANNEL_ID and $MOZ_PRODUCT_VERSION environment variables to allow for this at run time.

Updated

3 years ago
Blocks: 770995
(Assignee)

Comment 1

3 years ago
Created attachment 8445637 [details] [diff] [review]
Bug-1029870.patch

Adding patch.

Note: The strange order of appending flags to the `$mar_command` is because the -c <output_file> flag needs to be at the end, else everything after the -c flag is treated as a filename

Probably because of the way args are handled here: http://hg.mozilla.org/mozilla-central/file/a19e0434ea52/modules/libmar/tool/mar.c#l155
Assignee: nobody → ffledgling
Status: NEW → ASSIGNED
Attachment #8445637 - Flags: review?(nthomas)
Comment on attachment 8445637 [details] [diff] [review]
Bug-1029870.patch

Tested fine on our win32/mac/linux64 systems. If this works in the service too we can go ahead and land it.
Attachment #8445637 - Flags: review?(nthomas) → review+
(Assignee)

Comment 3

3 years ago
How do we make sure it works in service as well?
Comment on attachment 8445637 [details] [diff] [review]
Bug-1029870.patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa5aac520f6

Expect the sheriffs to merge this to m-c within a day, closing the bug when they do.
Attachment #8445637 - Flags: checked-in+
https://hg.mozilla.org/mozilla-central/rev/3fa5aac520f6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.