1029947 - [B2G][NFC] demo app to support bug 979152

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

WIP demo app source code is here: https://github.com/tauzen/HCI-Event-Demo. This version uses obsolete Gecko patch from Bug 979767 to get the HCI EVT_TRANSACTION notification.

There is still an ongoing discussion about how to deliver the notification to Gaia app, see here Bug 1037380 and here https://groups.google.com/d/topic/mozilla.dev.webapi/oER2OLg40pg/discussion. Once this will be agreed and implemented in gecko, the app will be updated.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Krzysztof,
Can you set the target milestone to either sprint2 or sprint3?

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Done. As this is a test app I'm not sure where in gaia should I place this. Should I add this to dev_apps folder?

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Maybe Alive can help to suggest. We do need to place the demo app somewhere (engineering build), but not necessary in user build.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Yes, dev_apps is where you could place any test apps.

Comment 6

[Ken Chang[:kenkai]]

Hi, do you have any update for this bug? We need to land this bug before 8/29. Thanks.

Comment 7

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1029947.txt

Assuming that there won't be much changes introduced in Bug 979767, this could be landed. It's working for me with the latest code from Garners development branch.

Who could review this?

Comment 8

[Krzysztof Mioduszewski[:tauzen]]

Hello Tim,

This is a demo app for testing user story from Bug 979152. It will be used by QA so I want to land this in gaia dev_apps. Could you point out a person who could review this?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can rubberstamp this. We actually against putting things as a new app (API manual tests/demo should be put in UI Test app), however since this app needs to handle system message, we might as well put one more app into dev_apps.

Comment 10

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8476612 [details] [review]
pull-request-1029947.txt

Hi Tim, since the decision in Bug 979767 was made to use only system-message it would be good if you could review this. 

Changes to the app should not be needed, we might require to change one property name in the manifest file.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/d92e717caf5ecdd43a4d4590ece2cf00db0cfbe9