[B2G][NFC] demo app to support bug 979152

RESOLVED FIXED in 2.1 S3 (29aug)

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: wesley_huang, Assigned: tauzen)

Tracking

unspecified
2.1 S3 (29aug)
Other
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.1, tracking-b2g:backlog, b2g-v2.1 fixed)

Details

User Story

Scope: the demo app is for showing HCI event/notifications

Attachments

(1 attachment)

Comment hidden (empty)
Blocks: 979152, 979154, 979157
blocking-b2g: --- → backlog
feature-b2g: --- → 2.1
Summary: [B2G][NFC] demo app to support 979152, 979154, 979157 → [B2G][NFC] demo app to support bug 979152, bug 979154, bug 979157
Assignee: nobody → kmioduszewski
No longer blocks: 979154, 979157
Summary: [B2G][NFC] demo app to support bug 979152, bug 979154, bug 979157 → [B2G][NFC] demo app to support bug 979152
User Story: (updated)

Updated

5 years ago
QA Whiteboard: [COM=NFC]
(Assignee)

Comment 1

4 years ago
WIP demo app source code is here: https://github.com/tauzen/HCI-Event-Demo. This version uses obsolete Gecko patch from Bug 979767 to get the HCI EVT_TRANSACTION notification.

There is still an ongoing discussion about how to deliver the notification to Gaia app, see here Bug 1037380 and here https://groups.google.com/d/topic/mozilla.dev.webapi/oER2OLg40pg/discussion. Once this will be agreed and implemented in gecko, the app will be updated.
Depends on: 979767
Hi Krzysztof,
Can you set the target milestone to either sprint2 or sprint3?
(Assignee)

Comment 3

4 years ago
Done. As this is a test app I'm not sure where in gaia should I place this. Should I add this to dev_apps folder?
Depends on: 1037380
Target Milestone: --- → 2.1 S3 (29aug)
Maybe Alive can help to suggest. We do need to place the demo app somewhere (engineering build), but not necessary in user build.
Flags: needinfo?(alive)
Yes, dev_apps is where you could place any test apps.
Flags: needinfo?(alive)
Hi, do you have any update for this bug? We need to land this bug before 8/29. Thanks.
Flags: needinfo?(kmioduszewski)
(Assignee)

Comment 7

4 years ago
Created attachment 8476612 [details] [review]
pull-request-1029947.txt

Assuming that there won't be much changes introduced in Bug 979767, this could be landed. It's working for me with the latest code from Garners development branch.

Who could review this?
(Assignee)

Updated

4 years ago
Flags: needinfo?(kmioduszewski)
(Assignee)

Comment 8

4 years ago
Hello Tim,

This is a demo app for testing user story from Bug 979152. It will be used by QA so I want to land this in gaia dev_apps. Could you point out a person who could review this?
Flags: needinfo?(timdream)
I can rubberstamp this. We actually against putting things as a new app (API manual tests/demo should be put in UI Test app), however since this app needs to handle system message, we might as well put one more app into dev_apps.
Flags: needinfo?(timdream)
(Assignee)

Comment 10

4 years ago
Comment on attachment 8476612 [details] [review]
pull-request-1029947.txt

Hi Tim, since the decision in Bug 979767 was made to use only system-message it would be good if you could review this. 

Changes to the app should not be needed, we might require to change one property name in the manifest file.
Attachment #8476612 - Flags: review?(timdream)
Attachment #8476612 - Flags: review?(timdream) → review+

Updated

4 years ago
QA Whiteboard: [COM=NFC]
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/d92e717caf5ecdd43a4d4590ece2cf00db0cfbe9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.