1029969 - Make compositor animation (OMTA) tests ignore floating-point differences

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Brian Birtles (:birtles)]

Some of the tests for off-main thread animations (OMTA) fail on Android due to minor differences in floating-point representation. Typically we have a tolerance factor that covers this but for a couple of tests we don't. Specifically:

* test_animations_omta_start.html expects the values to match exactly
* test_animations_omta.html has one check that tests around bug 978833 that also expects the values to match exactly.

We should update these tests to include a tolerance factor so that all tests pass when we turn on OMTA on Android.

Comment 1

[Brian Birtles (:birtles)]

Attachment: Make compositor animation (OMTA) tests ignore floating-point differences

Comment 2

[David Zbarsky (:dzbarsky)]

Comment on attachment 8446259 [details] [diff] [review]
Make compositor animation (OMTA) tests ignore floating-point differences

Review of attachment 8446259 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.  Out of curiousity, why did this only affect Android?

Comment 3

[Brian Birtles (:birtles)]

(In reply to David Zbarsky (:dzbarsky) from comment #2)
> Comment on attachment 8446259 [details] [diff] [review]
> Make compositor animation (OMTA) tests ignore floating-point differences
> 
> Review of attachment 8446259 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems reasonable.  Out of curiousity, why did this only affect Android?

No idea. It was only a minor difference like 50 vs 50.00000003 or something of that order. So it could be some difference in floating-point representation. I didn't dig into it since I don't have an Android debug environment set up.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41ba073e102d