1029989 - Rename private_tabs_panel_description to reflect new string content

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Francesco Lodolo [:flod]]

This is not OK
http://hg.mozilla.org/mozilla-central/rev/0f335eff972f

I'd be fine with the change "any form of" -> "any of", not with the addition of "bookmarks".

https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Oh, nice catch - sorry about that.

This string is currently only in Nightly (33) and the original string landed in Nightly a week prior to the change (both in the same bug). Should the entity name still be updated? Are the strings pushed to the localizer's tools as soon as the entity lands in m-c?

Comment 2

[Francesco Lodolo [:flod]]

If it landed on master, yes, you need a new ID (it's marked as untranslated as soon as it lands on mozilla-central).

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Update empty private tabs page entity name.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6fe53d58d0ae

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6fe53d58d0ae