1030042 - [B2G] use notifyDialSuccess(callIndex) for Cdma features

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This is a follow-up bug for Bug 1013745. We missed cdma cases ...

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 1030042.patch

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8445773 [details] [diff] [review]
1030042.patch

Review of attachment 8445773 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks.

::: dom/telephony/gonk/TelephonyService.js
@@ +438,5 @@
>        aTelephonyCallback.notifyDialError(errorMsg);
>        return;
>      }
>  
> +    function onCdmaDialSuccess(response) {

We don't need the whole response object. Simply pass callIndex here is sufficient.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #2)
> Comment on attachment 8445773 [details] [diff] [review]
> 1030042.patch
> 
> Review of attachment 8445773 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM. Thanks.
> 
> ::: dom/telephony/gonk/TelephonyService.js
> @@ +438,5 @@
> >        aTelephonyCallback.notifyDialError(errorMsg);
> >        return;
> >      }
> >  
> > +    function onCdmaDialSuccess(response) {
> 
> We don't need the whole response object. Simply pass callIndex here is
> sufficient.

Thanks for the review. Will do this in the final version.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/04b5fcba2af2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04b5fcba2af2