1030141 - crash in java.lang.IllegalStateException: Default panel in HomeConfig state is undefined at org.mozilla.gecko.home.HomeConfig$Editor.initFromState(HomeConfig.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-68d3fb1a-6a0f-482a-87f8-719572140624.
=============================================================

java.lang.IllegalStateException: Default panel in HomeConfig state is undefined
	at org.mozilla.gecko.home.HomeConfig$Editor.initFromState(HomeConfig.java:1117)
	at org.mozilla.gecko.home.HomeConfig$Editor.<init>(HomeConfig.java:1080)
	at org.mozilla.gecko.home.HomeConfig$Editor.<init>(HomeConfig.java:1056)
	at org.mozilla.gecko.home.HomeConfig$State.edit(HomeConfig.java:1035)
	at org.mozilla.gecko.preferences.PanelsPreferenceCategory$1.onPostExecute(PanelsPreferenceCategory.java:58)
	at org.mozilla.gecko.util.UiAsyncTask$BackgroundTaskRunnable$1.run(UiAsyncTask.java:56)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5086)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Comments 

> Ao abrir Configurações > Personalizar > Página Inicial o navegador encerra.

  When you open Settings> Personalize> Home closes the browser.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Margaret - Possible fallout from Recent Tabs?

Comment 2

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Margaret - Possible fallout from Recent Tabs?

I'll take a look. Setting the dependency in case it is, just so we don't lose track.

Comment 3

[Lucas Rocha (:lucasr)]

FYI: This is likely to be fixed by the patch in bug 1029046. The config migration added in bug 1004850 was not ensuring that the new config state contained a default panel.

Comment 4

[Lucas Rocha (:lucasr)]

Steps to verify this bug:
1. Install a nightly built before bug 1030141 landed with a fresh profile.
2. Disable all built-in panels in Settings -> Customize -> Home.
3. about:home will only show the Firefox watermark now.
4. Install new nightly with this fix included.
5. You should still see the same Firefox watermark in about:home.
6. Go to Settings -> Customize -> Home, it should not crash now.

Comment 5

[Lucas Rocha (:lucasr)]

This is very likely fixed by the patch bug 1029046. Please verify with the STR in comment #4.

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Samsung GT-P7510
OS: Android 4.0.4
1. Install the 22-06 build
2. Disable all panels from Settings
3. Update to latest Nightly 04-07 build 
4. Firefox watermark is present in about:home.
5. Go to Settings -> Customize -> Home
"Set as default", "Show" and "Change order" options now can be performed with no issues.