Closed Bug 1030215 Opened 5 years ago Closed 5 years ago
[Smart Collections] SC contextual menu is not localized
The contextual menu ("Add to top of collection", "Save to Homescreen") is not localized. 1. Switch to Italian 2. Open a SC 3. Long press on a SC icon Actual: The menu is not localized Expected: The menu is localized Note, we already have those strings in apps/collection/collection.properties Added qawanted to test on 2.0 Tested on Flame 2.1: Gaia 2944695a89c3281d49dbe5ff9c0cd26c8318e2ba Gecko https://hg.mozilla.org/mozilla-central/rev/215b93e07e1d BuildID 20140624160202 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014
I'll look into this.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S5 (4july)
No new strings, but this should probably block as it's a translation problem.
blocking-b2g: --- → 2.0?
Turns out the initial arguments were wrong. This would be another reason to stop using strings in our HTML :)
(In reply to Kevin Grandon :kgrandon from comment #3) > Created attachment 8446759 [details] [review] > Github pull request > > Turns out the initial arguments were wrong. This would be another reason to > stop using strings in our HTML :) Thanks Kevin! Also, Accented English locale can help detecting that (available in Engineering builds)
Comment on attachment 8446759 [details] [review] Github pull request This is too easy, and not worth a review, r=me. https://github.com/mozilla-b2g/gaia/commit/964dd02d8727652420c77662db64419c36be60cf
Attachment #8446759 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
This issue has been successfully verified on Flame 2.0: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141201000201 Version 32.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.1: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0 Device-Name flame FW-Release 4.4.2
You need to log in before you can comment on or make changes to this bug.