1030323 - Easy to hit "undo" after tab close when trying to "raise" next tab

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Andrew Overholt [:overholt]]

STR:

1. have 2 tabs open (any sites; doesn't matter)
2. close the second tab via the 'x' or side-swiping in the tab management view
3. attempt to "raise" the content of the tab that remains open to view it
4. press near the reader mode button to bring the content up

Actual:
- often hit "undo" from previous tab close since "undo" so close to where my right thumb presses to bring page content up

Expected:
- never hit tab close "undo" unintentionally

I can attach a video from another phone if it'll help.  I showed ibarlow in person, FWIW.

Comment 1

[:Margaret Leibovic]

We landed bug 1019735 to hide the toast when you touch elsewhere on the screen, but I suppose this doesn't help you if the first thing you want to touch is the content of the tab. Not sure what's the best solution here.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Interesting situation you're hitting here. I'd say there's a lot of questions to be asked, even "if I have only 1 tab, why do I have to pull up on it?" to just throw one out there.

I've definitely run into a sticky situation once or twice along these lines and I'll look to keep this in the back of my head as I think about the tab tray interactions as a whole.

Thanks for pointing it out!

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

These sorts of situations make me think we should be using gMail style undo where the closed tab is replaced with an undo button.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> These sorts of situations make me think we should be using gMail style undo
> where the closed tab is replaced with an undo button.

That is the longer term goal. Just isn't going to happen for a release or two (or more).

Comment 5

[Ian Barlow (:ibarlow)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> These sorts of situations make me think we should be using gMail style undo
> where the closed tab is replaced with an undo button.

+1

Comment 6

[Aaron Train [:aaronmt]]

Is this a 34 thing?

Comment 7

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #6)
> Is this a 34 thing?

This is a result of the tabs improvements we're planning to ship in 33, but I think we're okay shipping with this bug.

Implementing the "gmail-style" undo in place of the tab would also involve modifying the tabs tray, so we should probably hold off on that until the dust settles on some of the planned tabs tray changes.

Comment 8

[:Margaret Leibovic]

From triage: Our quick fix proposal is to just move the toast up above the address bar in this case.

antlam, what do you think of that?

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Conceptually this sounds fine for now. Do we have a build of this anywhere? Because I do have concerns around moving it _too_ far up and maybe even blocking another tab and not being that legible. But, I could be wrong.

Comment 10

[:Margaret Leibovic]

Attachment: experiment: moving toast up

Tried this out. It looks pretty awkward because the toast background blends into the tabs tray background.

Perhaps instead we should move the toast *down* so you can click on the toolbar?

I'm tempted to just WONTFIX this bug. Users can touch outside the toast to make it go away, and even if they don't, it is still possible to touch around it to click on the content area.

Comment 11

[Brian Nicholson (:bnicholson)]

(In reply to :Margaret Leibovic from comment #10)
> I'm tempted to just WONTFIX this bug. Users can touch outside the toast to
> make it go away, and even if they don't, it is still possible to touch
> around it to click on the content area.

UX liked the suggestion from comment 3, so maybe that's something we can move toward. Replacing a tab entry with an undo view would probably be less difficult than trying to hack the toast.

Comment 12

[:Margaret Leibovic]

(In reply to Brian Nicholson (:bnicholson) from comment #11)
> (In reply to :Margaret Leibovic from comment #10)
> > I'm tempted to just WONTFIX this bug. Users can touch outside the toast to
> > make it go away, and even if they don't, it is still possible to touch
> > around it to click on the content area.
> 
> UX liked the suggestion from comment 3, so maybe that's something we can
> move toward. Replacing a tab entry with an undo view would probably be less
> difficult than trying to hack the toast.

Yuan, do you have any thoughts about how an inline "gmail-style" undo close tab option could work? One challenge would be finding room for this in the horizontal tabs tray layout, as well as the sidebar tabs on tablets.

I don't think we'll be able to make this kind of change for Firefox 33, but maybe we can try to find a solution for 34. I'm just worried there will be multiple edge cases to deal with.

Comment 13

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

After checking in with Anthony and Margaret, I think this is a WONTFIX issue. 

First, this issue is an edge case, considering it affects only phones not tablets(since a tablet has larger screen space). Besides, we have already had designed solutions to avoid this incidence, for example time out the toast, and tap out to dismiss the toast. 

Second, We need to maintain consistency between our phone and tablet UI. UX has already been designing the tab tray for tablet redesign based on our current tab metaphor. Though the gmail way of undo is a nice touch, it requires lots of engineering work to restructure the UI especially considering how it may affect tablet UI as well.
 
As being said, this is a great catch. We should keep in mind with this issue while making changes around tab tray.