1030357 - Enable devtools/projecteditor tests with e10s

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Brian Grinstead [:bgrins]]

Looks like all of the tests are currently failing when running mach mochitest-devtools --e10s browser/devtools/projecteditor/:


 0:18.89 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/projecteditor/test/browser_projecteditor_app_options.js | uncaught exception - NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFocusManager.getFocusedElementForWindow] at chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1528
 0:18.89 Stack trace:
 0:18.89     JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 1345
 0:18.89     JS frame :: chrome://mochikit/content/mochitest-e10s-utils.js :: e10s_init/< :: line 74
 0:18.89     native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
 0:18.89 JavaScript error: chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js, line 1528: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFocusManager.getFocusedElementForWindow]

Comment 1

[Brian Grinstead [:bgrins]]

Current failures can be seen at https://tbpl.mozilla.org/?tree=Holly (for example: https://tbpl.mozilla.org/php/getParsedLog.php?id=46490101&tree=Holly&full=1)

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: projecteditor-e10s-skip.patch

Just skips the tests for now, since they are failing on Holly.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=ab1842664b62

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f71f3d5f8345

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f71f3d5f8345

Comment 5

[Chris Peterson [:cpeterson]]

Moving DevTools test bugs to e10s milestone M7 (i.e. not blocking e10s merge to Aurora).

Comment 6

[Eddy Bruel [:ejpbruel]]

Hi Brian. What's the status on this bug?

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Eddy Bruel [:ejpbruel] from comment #6)
> Hi Brian. What's the status on this bug?

The project editor works fine within the Web IDE when e10s is enabled, but unfortunately the tests are trickier to update than I was hoping.

Basically, in all the tests right now we end up passing a CPOW iframe into the ProjectEditor constructor: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/projecteditor/test/head.js#117.  It seems this is causing issues with detecting the load event on that object.  To move this object into a frame script it seems like we would need to change all of this interfacing with the projecteditor object in the test suite to use some kind of message passing: https://dxr.mozilla.org/mozilla-central/search?q=path%3Abrowser%2Fdevtools%2Fprojecteditor%2Ftest+%22projecteditor.%22&redirect=true.

I hope I'm missing something obvious that would allow us to work around this, or at least to pass this object back and forth in with the frame script - but it's not JSON serializable (it has DOM nodes attached, for instance).

Comment 8

[Brian Grinstead [:bgrins]]

Maybe we could change this to load the projecteditor URL to load into a toolbox like Patrick is doing with many of the shared/ tests in Bug 1034512.

Comment 9

[Brian Grinstead [:bgrins]]

Attachment: enable-projecteditor-e10s.patch

Oddly, this started working locally today when I ran it and try confirms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=587048a4e34c

Comment 10

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8574174 [details] [diff] [review]
enable-projecteditor-e10s.patch

Review of attachment 8574174 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why these tests suddenly started working. Most likely this is due recent change to the platform.

Since everything looks ok on try, I see no reason not to land these.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/78506bbeb2ef

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78506bbeb2ef