1030431 - When in incoming call screen the SR can land on select audio channel element that should be invisible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

If the screen reader is enabled and there's an incoming phone call we can land on an invisible select audio channel element. It should be hidden properly with CSS.

Comment 1

[Eitan Isaacson [:eeejay]]

Re-aligning priorities with 2.1 accessibility goals.

Comment 2

[Jim Ackley]

(In reply to Yura Zenevich [:yzen] from comment #0)
> If the screen reader is enabled and there's an incoming phone call we can
> land on an invisible select audio channel element. It should be hidden
> properly with CSS.

I'd like to try my hand at fixing this.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Jim Ackley from comment #2)
> (In reply to Yura Zenevich [:yzen] from comment #0)
> > If the screen reader is enabled and there's an incoming phone call we can
> > land on an invisible select audio channel element. It should be hidden
> > properly with CSS.
> 
> I'd like to try my hand at fixing this.

Go for it :).

FYI, it is fairly difficult to test without the actual device with a working SIM. Let me know if you don't have it and I can suggest another bug.

Note: you can not actually see the element. It is off-screen and only visible when the screen reader is enabled. To navigate you need to swipe left or right all the way until the focus is gone from the screenn.

Comment 4

[Jim Ackley]

(In reply to Yura Zenevich [:yzen] from comment #3)
> (In reply to Jim Ackley from comment #2)
> > (In reply to Yura Zenevich [:yzen] from comment #0)
> > > If the screen reader is enabled and there's an incoming phone call we can
> > > land on an invisible select audio channel element. It should be hidden
> > > properly with CSS.
> > 
> > I'd like to try my hand at fixing this.
> 
> Go for it :).
> 
> FYI, it is fairly difficult to test without the actual device with a working
> SIM. Let me know if you don't have it and I can suggest another bug.

I'm realizing this now. Shoot. I'm open to any suggestions you have.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Fix with a Gaia UI a11y test.

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8468734 [details] [review]
Github pull request.

Nice trick to fix it without logic changes.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/72bb113df0d50e179925e1ad33d6b811559331aa