Closed Bug 1030431 Opened 9 years ago Closed 8 years ago

When in incoming call screen the SR can land on select audio channel element that should be invisible.

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S2 (15aug)

People

(Reporter: yzen, Assigned: yzen, Mentored)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1][good first bug])

Attachments

(1 file)

If the screen reader is enabled and there's an incoming phone call we can land on an invisible select audio channel element. It should be hidden properly with CSS.
Re-aligning priorities with 2.1 accessibility goals.
Whiteboard: [b2ga11y p=1]
Whiteboard: [b2ga11y p=1] → --do_not_change-- [good first bug]
Whiteboard: --do_not_change-- [good first bug] → [b2ga11y p=1][good first bug]
Mentor: yzenevich
(In reply to Yura Zenevich [:yzen] from comment #0)
> If the screen reader is enabled and there's an incoming phone call we can
> land on an invisible select audio channel element. It should be hidden
> properly with CSS.

I'd like to try my hand at fixing this.
(In reply to Jim Ackley from comment #2)
> (In reply to Yura Zenevich [:yzen] from comment #0)
> > If the screen reader is enabled and there's an incoming phone call we can
> > land on an invisible select audio channel element. It should be hidden
> > properly with CSS.
> 
> I'd like to try my hand at fixing this.

Go for it :).

FYI, it is fairly difficult to test without the actual device with a working SIM. Let me know if you don't have it and I can suggest another bug.

Note: you can not actually see the element. It is off-screen and only visible when the screen reader is enabled. To navigate you need to swipe left or right all the way until the focus is gone from the screenn.
Assignee: nobody → ackley
(In reply to Yura Zenevich [:yzen] from comment #3)
> (In reply to Jim Ackley from comment #2)
> > (In reply to Yura Zenevich [:yzen] from comment #0)
> > > If the screen reader is enabled and there's an incoming phone call we can
> > > land on an invisible select audio channel element. It should be hidden
> > > properly with CSS.
> > 
> > I'd like to try my hand at fixing this.
> 
> Go for it :).
> 
> FYI, it is fairly difficult to test without the actual device with a working
> SIM. Let me know if you don't have it and I can suggest another bug.

I'm realizing this now. Shoot. I'm open to any suggestions you have.
Assignee: ackley → nobody
Attached file Github pull request.
Fix with a Gaia UI a11y test.
Attachment #8468734 - Flags: review?(anthony)
Assignee: nobody → yzenevich
Comment on attachment 8468734 [details] [review]
Github pull request.

Nice trick to fix it without logic changes.
Attachment #8468734 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/72bb113df0d50e179925e1ad33d6b811559331aa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.