1030468 - [AccessFu] VC rectangle needs to work with scaled content

Status: RESOLVED FIXED

Description

[Yura Zenevich [:yzen]]

Currently VC rectangle does not take into account scaled content. You can see the example of it in the browser app in Gaia, when loading some classic (non-mobile) website.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: User content window resolution to scale bounding boxes before presentation.

Got rid of the viewport code, instead use the content window resolution to scale the coordinates. Tested on Android to make sure it works there too.

Comment 2

[Yura Zenevich [:yzen]]

Comment on attachment 8474063 [details] [diff] [review]
User content window resolution to scale bounding boxes before presentation.

Review of attachment 8474063 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a couple of comments. thanks!

::: accessible/jsat/Utils.jsm
@@ +295,5 @@
>  
> +  getBounds: function getBounds(aAccessible, aPreserveContentScale) {
> +    let objX = {}, objY = {}, objW = {}, objH = {};
> +    aAccessible.getBounds(objX, objY, objW, objH);
> +    let scaleX = { value: 1 }, scaleY = { value: 1 };

Nit: line 299 should be consistent with line 317. This one is nicer, imho.

@@ +298,5 @@
> +    aAccessible.getBounds(objX, objY, objW, objH);
> +    let scaleX = { value: 1 }, scaleY = { value: 1 };
> +
> +    if (!aPreserveContentScale) {
> +      aAccessible.document.window.QueryInterface(

Nit: Lets put scale calculation into its own function?

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b12f5f4b5cb

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9b12f5f4b5cb