Seeking hangs due to time truncation in Media Source Extensions

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cajbir, Assigned: cajbir)

Tracking

(Blocks: 1 bug)

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
MediaSourceDecoder truncates target time during seek due to integer division:

  AllContainsTime (aTime / USECS_PER_S)

aTime is an int64_t.
(Assignee)

Updated

5 years ago
Blocks: 778617
(Assignee)

Comment 1

5 years ago
Posted patch FixSplinter Review
Assignee: nobody → cajbir.bugzilla
Status: NEW → ASSIGNED
Attachment #8446295 - Flags: review?(kinetik)
Comment on attachment 8446295 [details] [diff] [review]
Fix

Review of attachment 8446295 [details] [diff] [review]:
-----------------------------------------------------------------

Remove the space between AllContainsTime and ( in each case please.
Attachment #8446295 - Flags: review?(kinetik) → review+
(Assignee)

Comment 3

5 years ago
Pushed with review comment addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3d835981fc
https://hg.mozilla.org/mozilla-central/rev/dd3d835981fc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.