Closed
Bug 1030591
Opened 11 years ago
Closed 11 years ago
[Wifi] WifiManager.onconnectionInfoUpdate doesn't issue on IP address change.
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: chucklee, Assigned: chucklee)
References
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
vchang
:
review+
|
Details | Diff | Splinter Review |
Currently WifiManager.onconnectionInfoUpdate is only being issued while wifi signal or link speed changes, we should also issue this event while IP address changes.
|
||
Comment 1•11 years ago
|
||
I also noticed this bug when refactoring wifi panel in Settings app. We may need the patch to make onconnectionInfoUpdate work as what we thought !
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8447060 -
Flags: review?(vchang)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8447060 [details] [diff] [review]
Send connectionInfoUpdate while IP change.
Review of attachment 8447060 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Chuck, do you want to apply level 3?
Attachment #8447060 -
Flags: review?(vchang) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=e7e6283351ca
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Yeah, can't wait to try this on Gaia :P
|
|
||
Comment 6•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Updated•11 years ago
|
Target Milestone: --- → 2.0 S5 (4july)
|
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•