Closed Bug 1030606 Opened 6 years ago Closed 6 years ago

--disable-accessibility build error: "HTMLImageElement.cpp:979:43: error: 'picture' is not a member of 'nsGkAtoms'"

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

STR:
 Add ac_add_options --disable-accessibility to mozconfig and build.

ACTUAL RESULTS: Build failure:
{
content/html/content/src/HTMLImageElement.cpp:979:43: error: 'picture' is not a member of 'nsGkAtoms'
}

This happens because http://hg.mozilla.org/mozilla-central/rev/ea8a9d628260 mistakenly added GK_ATOM(picture, "picture") to an #ifdef ACCESSIBILITY chunk of nsGkAtomList.h.
Attached patch fix v1Splinter Review
This moves the GK_ATOM() line up to the section at the top labeled "Generic atoms" (which is where e.g. the line for "img" lives).
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8446366 - Flags: review?(jschoenick)
Comment on attachment 8446366 [details] [diff] [review]
fix v1

r=mats, please land :-)
Attachment #8446366 - Flags: review?(jschoenick) → review+
I had some other stuff to land so I pushed this too:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5781ef0d10
Flags: in-testsuite-
(In reply to Daniel Holbert [:dholbert] from comment #0)
> This happens because http://hg.mozilla.org/mozilla-central/rev/ea8a9d628260
> mistakenly added GK_ATOM(picture, "picture") to an #ifdef ACCESSIBILITY
> chunk of nsGkAtomList.h.

Whoops! Thanks for catch & fix.
(In reply to Mats Palmgren (:mats) from comment #3)
> I had some other stuff to land so I pushed this too:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5781ef0d10

Thanks!
https://hg.mozilla.org/mozilla-central/rev/cf5781ef0d10
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.