1030606 - --disable-accessibility build error: "HTMLImageElement.cpp:979:43: error: 'picture' is not a member of 'nsGkAtoms'"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

STR:
 Add ac_add_options --disable-accessibility to mozconfig and build.

ACTUAL RESULTS: Build failure:
{
content/html/content/src/HTMLImageElement.cpp:979:43: error: 'picture' is not a member of 'nsGkAtoms'
}

This happens because http://hg.mozilla.org/mozilla-central/rev/ea8a9d628260 mistakenly added GK_ATOM(picture, "picture") to an #ifdef ACCESSIBILITY chunk of nsGkAtomList.h.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: fix v1

This moves the GK_ATOM() line up to the section at the top labeled "Generic atoms" (which is where e.g. the line for "img" lives).

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8446366 [details] [diff] [review]
fix v1

r=mats, please land :-)

Comment 3

[Mats Palmgren (inactive)]

I had some other stuff to land so I pushed this too:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5781ef0d10

Comment 4

[John Schoenick [:johns]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> This happens because http://hg.mozilla.org/mozilla-central/rev/ea8a9d628260
> mistakenly added GK_ATOM(picture, "picture") to an #ifdef ACCESSIBILITY
> chunk of nsGkAtomList.h.

Whoops! Thanks for catch & fix.

Comment 5

[Daniel Holbert [:dholbert] (PTO until 2/24)]

(In reply to Mats Palmgren (:mats) from comment #3)
> I had some other stuff to land so I pushed this too:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/cf5781ef0d10

Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf5781ef0d10