1030623 - [Dialer] No space between text and border when Contact with long name and number matching hits

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: CallLogMatching.png

### STR
1. Have an entry with long name in Contacts.
2. Type the number in Dial pad until only 1 match comes up.

### Actual 
The space between screen border and text is too small, not the same width as on the left side.

### Reproduce rate
100% on v2.0
Not happening on v1.4

### Version
Flame v2.0 aurora 
Gaia      c478c43229883cee2afd09c6edb42d29a46cc500
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/8940337ccb5c
BuildID   20140625160200
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
t2m.sw.version=B1TC00011220

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: FYI CallLogMatchingMoreThanOne.png

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: v1.4

Comment 3

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/be4a76145a093e66bd70f4cfd8f82323a9a50a3c

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Paco, please contact Mari Ángeles in case asking for approval to land the patch in v2.0 and v1.4 is needed ;) Thanks!

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Ups, sorry! It seems it does not affect v1.4 and v2.0 is the only one affected ;)

Comment 7

[Maria Angeles Oteo (:oteo)]

Not feedback received yet about if it's too late for the approval to 2.0... let's try it, very small and css patch.

Comment 8

[Paco Rampas [:paco]]

Comment on attachment 8458622 [details] [review]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual refresh
[User impact] if declined: incorrect UI
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): no risk
[String changes made]: none

Comment 9

[Anthony Ricaud (:rik)]

FWIW, I'm ok uplifting this.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/95a2038c5e92c0c9527590d323fdce22f28c06d1

Comment 11

[Eric Chang [:ericcc] [:echang]]

(In reply to Germán Toro del Valle from comment #4)
> Landed in master:
> https://github.com/mozilla-b2g/gaia/commit/
> be4a76145a093e66bd70f4cfd8f82323a9a50a3c

Hi German, I still can reproduce this on v2.1, could you check that, thank you.

FAIL - Flame v2.1
Gaia      15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko     https://hg.mozilla.org/mozilla-central/rev/30907d52c4c2
BuildID   20140723160203
Version   34.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC0001122

OK - Flame v2.0
Gaia      91986777d0942b63e37fbfeec19d69d6176d6d74
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/392054b2e899
BuildID   20140723160206
Version   32.0
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Comment 12

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.1_Offcenter.png

When the text goes outside the edge, you can drag the upper part and move the whole screen.
https://www.youtube.com/watch?v=1x-7zmPZ8nQ

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Passing the need-info to Paco since he proposed the patch which should have solved the issue ;) See comment 11, Paco, please.

Comment 14

[Paco Rampas [:paco]]

The issue isn't related with this bug. But I can fix it. I am opening other bug to fix it. Thanks Eric.

Comment 15

[Eric Chang [:ericcc] [:echang]]

Hi Paco, Is this patch working on v2.1?
https://github.com/mozilla-b2g/gaia/commit/be4a76145a093e66bd70f4cfd8f82323a9a50a3c
I still got something like the text goes outside the screen..
https://bugzilla.mozilla.org/attachment.cgi?id=8461344

(In reply to Paco Rampas [:paco] from comment #14)
> The issue isn't related with this bug. But I can fix it. I am opening other
> bug to fix it. Thanks Eric.

Comment 16

[Paco Rampas [:paco]]

The issue is still on master, but the issue that you comment isn't causing for this bug. I have opened and fix the horizontal overflow scroll on this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1043318

Could you check if the description of bug is ok?

Comment 17

[Eric Chang [:ericcc] [:echang]]

Thanks for checking, so the issue is still there, I just reopen this bug.
And as for the 1043318, if this 1030623 is fixed, maybe the side effort goes away.

Comment 18

[Paco Rampas [:paco]]

(In reply to Eric Chang [:ericcc] [:echang] from comment #17)
> Thanks for checking, so the issue is still there, I just reopen this bug.
> And as for the 1043318, if this 1030623 is fixed, maybe the side effort goes
> away.

Hello, this bug 1043318 has solved the issue of comment 12. Could we close this bug?

Comment 19

[Maria Angeles Oteo (:oteo)]

setting qawanted, so Eric can verify it, thanks!

Comment 20

[Joshua Mitchell (Inactive)]

I'm not sure the Qa-wanted tag will get his attention. Unless you were asking us to verify it as well, I'd go with a NI instead.

Comment 21

[Eric Chang [:ericcc] [:echang]]

Verified on flame v2.1
Gaia      19bf9795263e2ccc15d824a52ebf23c2670fa9b9
Gecko     https://hg.mozilla.org/mozilla-central/rev/7f81be7db528
BuildID   20140804160542
Version   34.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Comment 22

[Doug Sherk (:drs) (inactive)]

(In reply to Eric Chang [:ericcc] [:echang] from comment #21)
> Verified on flame v2.1
> Gaia      19bf9795263e2ccc15d824a52ebf23c2670fa9b9
> Gecko     https://hg.mozilla.org/mozilla-central/rev/7f81be7db528
> BuildID   20140804160542
> Version   34.0a1
> ro.build.version.incremental=109
> ro.build.date=Mon Jun 16 16:51:29 CST 2014
> B1TC00011220

Is it verified working as expected, or still not working? Can we close this bug?

Comment 23

[Eric Chang [:ericcc] [:echang]]

changing state..