1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: MatchingResults.png

### STR
1. Have an entry with long name in Contacts.
2. Have another entry with number that at least 3 digits are the same as in Step1.
3. Type the number in Dial pad, more than 2 contacts should show up.
4. Tap on the 3 dots.


### Actual 
Text not align.
See MatchingResults.png 

### Reproduce rate
100% on v2.0
Not happening if the contact's name is short on v2.0
see MatchingResultsShortName.png
Not happening on v1.4

### Version
Flame v2.0 aurora 
Gaia      c478c43229883cee2afd09c6edb42d29a46cc500
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/8940337ccb5c
BuildID   20140625160200
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
t2m.sw.version=B1TC00011220

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: MatchingResultsShortName.png v2.0

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: v1.4 not happening

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

most-wanted but not blocking

Comment 4

[Jorge Prudencio [:jorgep]]

Attachment: [patch] Text not aligned when matches are more than 1 if contact has long name.png

Here is the result of the patch

Comment 5

[Jorge Prudencio [:jorgep]]

Attachment: 23077.html

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8475829 [details]
23077.html

Sorry, this patch bitrotted since you wrote it because the code is now shared with the Emergency Call app. Can you rebase and check that it works well with ICE contacts?

Comment 7

[Jorge Prudencio [:jorgep]]

Comment on attachment 8475829 [details]
23077.html

Hello Anthony, I have uploaded the patch. Now it works with ICE contacts. Thanks!

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8475829 [details]
23077.html

Thanks and sorry again for not reviewing this sooner.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/02af26b5d19d199c5a0b0cac23504970e4d10150