Closed Bug 1030704 Opened 11 years ago Closed 11 years ago

[Collection app] Divider under pinned apps hidden

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S5 (4july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: ranbena, Assigned: kgrandon)

References

Details

(Whiteboard: [p=1],[systemsfe])

Attachments

(4 files)

Actual.png
607.92 KB, image/png
Details
Expected.png
610.36 KB, image/png
Details
Github pull request
46 bytes, text/x-github-pull-request
ranbena
: review+
bajaj
: approval-gaia-v2.0+
Details | Review
verify_v2.1.png
610.94 KB, image/png
Details
STR: 1. Open "Music" collection 2. Wait till pinned apps and web results finish loading Expected: A divider appears between the two groups of apps. Actual: The divider is hidden.
Attached image Actual.png —
Attached image Expected.png —
Blocks: 1015336
Blocks: vertical-home-next
No longer blocks: 1015336
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
This is pretty ugly, let's fix it.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=1],[systemsfe]
Target Milestone: --- → 2.0 S5 (4july)
Attached file Github pull request —
Ran - could you review this? Thanks!
Attachment #8446700 - Flags: review?(ran)
Comment on attachment 8446700 [details] [review] Github pull request Looks like the best approach to me.
Attachment #8446700 - Flags: review?(ran) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 8446700 [details] [review] Github pull request This is a pretty bad visual blemish and is needed for the vertical homescreen.
Attachment #8446700 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8446700 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
This issue has been successfully verified on Flame 2.1&2.0. See attachment: verified_v2.1.png. Reproduce rate: 0/5 Flame 2.0 versions: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141130000204 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141130.032432 FW-Date Sun Nov 30 03:24:44 EST 2014 Bootloader L1TC00011880 Flame 2.1 versions: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141130001203 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141130.034738 FW-Date Sun Nov 30 03:47:49 EST 2014 Bootloader L1TC00011880
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: