1030708 - Test failure "Unknown property - identity.ownerUnknown2" in testSecurity/testDVCertificate.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andreea Matei [:AndreeaMatei]]

Started failing today on OS X so far, Nightly en-us. 
Affected line:
http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testDVCertificate.js#l69

I'll investigate this now, might be the property changed in chrome://browser/locale/browser.properties. I guess it will fail on the other platforms as well.

Comment 1

[Andreea Matei [:AndreeaMatei]]

Attachment: skip patch

Adding skip patch.

Comment 2

[Andreea Matei [:AndreeaMatei]]

This was changed in bug 1029862, by http://hg.mozilla.org/mozilla-central/rev/afbd2e8aa96e
That property was removed.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Actually I have the fix, we remove the owner check.

Comment 4

[Andrei Eftimie]

Comment on attachment 8446492 [details] [diff] [review]
patch v1

Review of attachment 8446492 [details] [diff] [review]:
-----------------------------------------------------------------

Landed:
https://hg.mozilla.org/qa/mozmill-tests/rev/844785a1d284 (default)

Thanks for the quick fix!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8446492 [details] [diff] [review]
patch v1

Review of attachment 8446492 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testDVCertificate.js
@@ -64,5 @@
>    var host = new elementslib.ID(controller.window.document, "identity-popup-content-host");
>    expect.equal(host.getNode().textContent, Services.eTLD.getBaseDomainFromHost(cert.commonName),
>                 "The site identifier string is equal to the cert host");
>  
> -  var owner = new elementslib.ID(controller.window.document, "identity-popup-content-owner");

Do we really only check the owner for DV certs but not for EV, and OV? If that is the case we should really get this fixed, and tests enhanced.

Comment 6

[Daniel Gherasim]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Comment on attachment 8446492 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8446492 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: firefox/tests/remote/testSecurity/testDVCertificate.js
> @@ -64,5 @@
> >    var host = new elementslib.ID(controller.window.document, "identity-popup-content-host");
> >    expect.equal(host.getNode().textContent, Services.eTLD.getBaseDomainFromHost(cert.commonName),
> >                 "The site identifier string is equal to the cert host");
> >  
> > -  var owner = new elementslib.ID(controller.window.document, "identity-popup-content-owner");
> 
> Do we really only check the owner for DV certs but not for EV, and OV? If
> that is the case we should really get this fixed, and tests enhanced.

We check the owner for EV certificates in testGreenLarry.js.
For the OV certificate I guess it should be the same as DV certificate, no owner.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So lets file a bug, so that we can coverage for that added.

Comment 8

[Daniel Gherasim]

Filed bug 1034484.

Comment 9

[Otilia Anica]

Info provided in comment 6.