Closed Bug 1030716 Opened 6 years ago Closed 6 years ago

Prevent dark theme in sourceeditor for WebIDE

Categories

(DevTools Graveyard :: WebIDE, defect)

x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: paul, Assigned: bgrins)

References

Details

Attachments

(1 file)

When the dark theme is used, itchpad turns dark and the toolbox as well. When the file list and the toolbar don't.

I see 2 options:
- not support the dark theme in webide
- support dark theme for file list, and (optional) the toolbar
My first thought here is to disable theming for the editor for now to make it feel less broken, then come back around to adding full theme support later (possibly under a different pref than the one being used by the toolbox).
(In reply to Brian Grinstead [:bgrins] from comment #1)
> My first thought here is to disable theming for the editor for now to make
> it feel less broken

Works for me. How to do that?
this does the trick.  What do you think? It adds a special attribute to the html element that theme-switching.js picks up and forces it to stick with the specified theme.

We can't just *not* include theme-switching.js unless if we want to do the StylesheetUtils.loadSheet stuff (and maybe forceStyle) inside of editor.js, but that would be an option too.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8446510 - Flags: feedback?(paul)
Attachment #8446510 - Flags: feedback?(paul) → review+
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=ee3d43d207d1
Summary: Do something about the dark theme in WebIDE → Prevent dark theme in sourceeditor for WebIDE
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/25e196a33884
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.