Closed
Bug 1030716
Opened 10 years ago
Closed 10 years ago
Prevent dark theme in sourceeditor for WebIDE
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: paul, Assigned: bgrins)
References
Details
Attachments
(1 file)
4.87 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
When the dark theme is used, itchpad turns dark and the toolbox as well. When the file list and the toolbar don't.
I see 2 options:
- not support the dark theme in webide
- support dark theme for file list, and (optional) the toolbar
Assignee | ||
Comment 1•10 years ago
|
||
My first thought here is to disable theming for the editor for now to make it feel less broken, then come back around to adding full theme support later (possibly under a different pref than the one being used by the toolbox).
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1)
> My first thought here is to disable theming for the editor for now to make
> it feel less broken
Works for me. How to do that?
Assignee | ||
Comment 3•10 years ago
|
||
this does the trick. What do you think? It adds a special attribute to the html element that theme-switching.js picks up and forces it to stick with the specified theme.
We can't just *not* include theme-switching.js unless if we want to do the StylesheetUtils.loadSheet stuff (and maybe forceStyle) inside of editor.js, but that would be an option too.
Reporter | ||
Updated•10 years ago
|
Attachment #8446510 -
Flags: feedback?(paul) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=ee3d43d207d1
Summary: Do something about the dark theme in WebIDE → Prevent dark theme in sourceeditor for WebIDE
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•