Prevent dark theme in sourceeditor for WebIDE

RESOLVED FIXED in Firefox 33

Status

()

Firefox
Developer Tools: WebIDE
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: paul, Assigned: bgrins)

Tracking

Trunk
Firefox 33
x86_64
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
When the dark theme is used, itchpad turns dark and the toolbox as well. When the file list and the toolbar don't.

I see 2 options:
- not support the dark theme in webide
- support dark theme for file list, and (optional) the toolbar
(Assignee)

Comment 1

4 years ago
My first thought here is to disable theming for the editor for now to make it feel less broken, then come back around to adding full theme support later (possibly under a different pref than the one being used by the toolbox).
(Reporter)

Comment 2

4 years ago
(In reply to Brian Grinstead [:bgrins] from comment #1)
> My first thought here is to disable theming for the editor for now to make
> it feel less broken

Works for me. How to do that?
(Assignee)

Comment 3

4 years ago
Created attachment 8446510 [details] [diff] [review]
no-dark-theme.patch

this does the trick.  What do you think? It adds a special attribute to the html element that theme-switching.js picks up and forces it to stick with the specified theme.

We can't just *not* include theme-switching.js unless if we want to do the StylesheetUtils.loadSheet stuff (and maybe forceStyle) inside of editor.js, but that would be an option too.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8446510 - Flags: feedback?(paul)
(Reporter)

Updated

4 years ago
Attachment #8446510 - Flags: feedback?(paul) → review+
(Assignee)

Comment 4

4 years ago
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=ee3d43d207d1
Summary: Do something about the dark theme in WebIDE → Prevent dark theme in sourceeditor for WebIDE
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/25e196a33884
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/25e196a33884
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.