1030735 - Enable devtools/styleinspector tests with e10s

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Comment 1

[Patrick Brosset <:pbro>]

Making this depend on bug 1034601 so I can benefit from a number of fixes made there that avoid exceptions thrown when the toolbox closes.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: bug1030735-enable-styleinspector-test-in-e10s-mode WIP.patch

WIP patch, not all tests have been migrated yet (about 90%).
What I've done so far:

- Removed global skip-if in brower.ini
- Refactored selectNode/getNodeFront in head.js
- Yielded on closeToolbox in cleanup function
- Moved the css-logic testing part out of browser_computedview_media-queries.js and into its own mochitest-chrome test
- Disabled a test because ctx-menu to inspect element doesn't work: filed bug 1039528
- Disabled eye-dropper test as not e10s compatible: filed bug 1040653
- Disabled style-editor link because of viewSourceUtils: filed bug 1040670
- Moved browser_styleinspector_csslogic-inherited-properties.js to a css-logic mochitest-chrome test instead, as it has nothing to do with the style-inspector
- Same for browser_styleinspector_csslogic-specificity.js
- Fixed all other tests so they pass with the --e10s option

About 10 tests left to migrate.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: bug1030735-enable-styleinspector-test-in-e10s-mode v1.patch

Finished migrating all tests. Rebased. And also removed browser_styleinspector_inplace-editor.js and instead created browser_inplace-editor.js in browser/devtools/shared/tests where it should have been the whole time.

Comment 4

[Patrick Brosset <:pbro>]

Attachment: bug1030735-enable-styleinspector-test-in-e10s-mode v2.patch

Minor bug fix in a test I changed.

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 8469487 [details] [diff] [review]
bug1030735-enable-styleinspector-test-in-e10s-mode v2.patch

Joe, here are my changes to the style-inspector tests so that they pass with e10s.
Here is a green try build to make sure they still pass in non-e10s too: https://tbpl.mozilla.org/?tree=Try&rev=814cfb3854e3

Comment 6

[Patrick Brosset <:pbro>]

Attachment: bug1030735-enable-styleinspector-test-in-e10s-mode v3.patch

Thanks Joe for the review.
Rebased this patch.
Also started a new try build for good measure: https://tbpl.mozilla.org/?tree=Try&rev=479f617d98a5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/34d31262fbfd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34d31262fbfd