1030736 - Don't include ignored about:home tabs in count to determine whether or not to show "Open all" button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Close_about:home_tab

Device: Samsung Galaxy Nexus
OS: Android 4.2
Build: Firefox for Android 33.0a1 (2014-06-25)

Steps to reproduce:
1. Open a few about:home tabs
2. Open the tab tray and choose "Close All Tabs" from the three dot menu
3. Go to "Recent Tabs"

Expected results:
- A name should appear in the "Recently closed tabs" list.
- "Open all" should restore all tabs opened at step 1.

Actual results:
- The "Recently closed tabs" is empty. 
- Tapping the "Open all" button does nothing.
- Please see attached screenshot

Comment 1

[Aaron Train [:aaronmt]]

Perhaps the 'Open All' button shouldn't be shown when the entire tab listing consists of about:home. There's really no need to restore it.

Comment 2

[:Margaret Leibovic]

The "Open all" button should only be displayed when there are 2 or more tabs listed. If it's displaying when there's no tabs, that's a bug.

Comment 3

[Teodora Vermesan (:TeoVermesan)]

If I open one new about:home tab and close it, the "Open all" option won't be displayed.
If I open  two new about:home tabs and close them, the option is present and when I tap it, nothing is done.

Comment 4

[:Margaret Leibovic]

Attachment: Don't include ignored about:home tabs in count to determine whether or not to show "Open all" button

Stupid about:home checks!

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/8241767aa510

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8241767aa510

Comment 7

[Teodora Vermesan (:TeoVermesan)]

With a clean profile, if I open 3 tabs of about:home and close them, the Recent Tabs panel is empty. If I open 2 tabs of about:home and 2 pages and close them, only the 2 pages appear in the "Recently closed tabs" from Recent Tabs. The same is in the "Tabs from last time" list: about:home tabs don't appear, so 
Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 33.0a1 (2014-07-02)