1030757 - Closed private tabs appears in recent tabs panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Flaviu Cos]

Environment: 
Device: Google Nexus 10 (Android 4.4.2);
Build: Nightly 33.0a1 (2014-06-26);

Steps to reproduce:
1. Open new private tab;
2. Load a page;
3. Close the private tab;
4. Go to Recent tabs panel in about:home.

Expected result:
The closed private tab is not listed in recently closed tabs.

Actual result:
The closed private tab appears in recently closed tabs.

Comment 1

[Aaron Train [:aaronmt]]

and it restores as a regular tab ....

Comment 2

[:Margaret Leibovic]

I can look into this tomorrow, since bnicholson is on PTO. We pull the recent tabs from session store, but maybe we don't separate private/regular tabs in there? I thought we did.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

Also related, recent tabs will list about:privatebrowsing (new private tabs), it seems unnecessary to list and capture essentially useless entries there.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Don't list closed private tabs in Recent Tabs panel

Omits any private tabs in the ClosedTabs:Data message.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Don't list closed private tabs in Recent Tabs panel

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Don't list closed private tabs in Recent Tabs panel, v2

forgot qref

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/6a2450c41a2e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a2450c41a2e

Comment 9

[Teodora Vermesan (:TeoVermesan)]

If I open in private mode, two tabs: about:privatebrowsing and google.com, close them, they will not be listed in recently closed tabs, so:
Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 33.0a1 (2014-07-09)