1030779 - Command-line help text missing -private-window flag

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Ryan N. Freebern [:rfreebern]]

Attachment: private-window-help-output.diff

While Firefox supports a -private-window command-line flag, it's not present in the command-line help output.

Expected: "-private-window" appears in output of "firefox -h"
Actual: "-private-window" is not present in the output of "firefox -h"
Steps to reproduce: Run "firefox -h" on the command line.

Comment 1

[(not currently active) Ted Mielczarek]

You've got a semicolon at the end of your added line where you want a +, but if I fix that it works fine locally:
https://pastebin.mozilla.org/5475946

Comment 2

[Josh Matthews [:jdm]]

If you upload a fixed version (following the instructions at https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F) this looks good to me!

Comment 3

[Ryan N. Freebern [:rfreebern]]

Attachment: Fixed patch.

Whoops. Here's a fixed patch.

Comment 4

[Ryan N. Freebern [:rfreebern]]

Attachment: hg mq patch

One more try, this time with an (I hope) properly-formatted patch.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8446604 [details] [diff] [review]
hg mq patch

Since jdm offered.

Comment 6

[Josh Matthews [:jdm]]

Comment on attachment 8446604 [details] [diff] [review]
hg mq patch

Review of attachment 8446604 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry that I forgot about this. Could you add a "Bug 1030779 - " prefix to the commit message, as well as "r=jdm" to the end of it? It will be ready to be merged in that case; thanks!

Comment 7

[Ryan N. Freebern [:rfreebern]]

Attachment: hg mq patch

Updated patch with properly-formatted commit msg.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b4c300eceeff

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b4c300eceeff

Comment 10

[Francesca Ciceri [:madamezou]]

Hi,

I've reproduced it on Nightly Mozilla Firefox 33.0a1 (20140626) and I can confirm it's fixed in latest Nightly Firefox/34.0 ID:20140723030202 on Linux x86_64.

Cheers,
Francesca