Refactor camera app object

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zac, Assigned: zac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
AndreiH
: review+
Bebe
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
The camera app object is a bit of a mess.

* Reduce/merge locators
* bolster logic and waits
* etc
(Assignee)

Updated

4 years ago
Assignee: nobody → zcampbell
(Assignee)

Comment 1

4 years ago
Created attachment 8447122 [details] [review]
git pr

adhoc:
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/39/
Attachment #8447122 - Flags: review?(florin.strugariu)
Attachment #8447122 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 2

4 years ago
Last one was no good, I hadn't rebased to pick up the latest marionette/runner.
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/40/
Comment on attachment 8447122 [details] [review]
git pr

Only a nit
Attachment #8447122 - Flags: review?(florin.strugariu) → review+

Updated

4 years ago
Attachment #8447122 - Flags: review?(andrei.hutusoru) → review+
(Assignee)

Comment 4

4 years ago
(In reply to Florin Strugariu [:Bebe] from comment #3)
> Comment on attachment 8447122 [details] [review]
> git pr
> 
> Only a nit

Yep one indentation was wrong
(Assignee)

Updated

4 years ago
Attachment #8447122 - Flags: review+ → review?(florin.strugariu)
Attachment #8447122 - Flags: review?(florin.strugariu) → review+
Do we want this on 2.0 too?
Flags: needinfo?(zcampbell)
(Assignee)

Comment 7

4 years ago
Nah, this is just an enhancement, no need for v2.0.
Flags: needinfo?(zcampbell)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.