103085 - Memory leak of 132 bytes from 1 block allocated in nsLDAPConnectionLoop::Init

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, defect, P3)

Description

[[e-mail] (gone - use [e-mail] instead)]

Trunk CVS pull, 8 pm 10-3-2001, Windows 2000.

Using the autocomplete setup provided by [e-mail].

dmose had asked a long time ago if I could run this, sorry it took so long.

Steps to Reproduce:

1.  Mozilla.exe -compose.
2.  Type dmos (it'll complete to Dan Mosedale <[e-mail]>).
3.  Tab to subject.
4.  Exit.


[W] MLK: Memory leak of 132 bytes from 1 block allocated in PR_Calloc
    Distribution of leaked blocks
    Allocation location
    calloc+0xc           [C:\WINNT\SYSTEM32\msvcrt.DLL ip=0x5800122b]
    PR_Calloc+0x31       [.\../../../../pr/src/malloc/prmem.c:59 ip=0x30018cb1]
    nsLDAPConnectionLoop::Init(void)+0x33 
[c:\moz_src\mozilla\directory\xpcom\base\src\nsLDAPConnection.cpp:573 
ip=0x0df48020]
    nsLDAPConnectionLoop::Init()
    {
        if (!mLock) {
 =>         mLock = PR_NewLock();
            if (!mLock) {
                NS_ERROR("nsLDAPConnectionLoop::Init: out of memory ");
                return NS_ERROR_OUT_OF_MEMORY;
    nsLDAPConnection::OnStopLookup(nsISupports *,char const*,UINT)+0x244 
[c:\moz_src\mozilla\directory\xpcom\base\src\nsLDAPConnection.cpp:973 
ip=0x0df49456]
                //
                mRunnable = new nsLDAPConnectionLoop();
                NS_ADDREF(mRunnable);
     =>         rv = mRunnable->Init();
                if (NS_FAILED(rv)) {
                    rv = NS_ERROR_OUT_OF_MEMORY;
                } else {
    XPTC_InvokeByIndex+0x75 
[c:\moz_src\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp:152 
ip=0x100d4c0e]
                mov     eax,methodIndex
                shl     eax,2               // *= 4
                add     edx,eax
     =>         call    [edx]               // stdcall, i.e. callee cleans up 
stack.
            }
        }
        #pragma warning(default : 4035) // restore default
    EventHandler+0xb4    
[c:\moz_src\mozilla\xpcom\proxy\src\nsProxyEvent.cpp:514 ip=0x100e4fb7]
                nsresult rv = XPTC_InvokeByIndex( proxyObject->GetRealObject(),
                                                  info->GetMethodIndex(),
                                                  info->GetParameterCount(),
     =>                                           info->GetParameterList());
                info->SetResult(rv);
            }
            else
    md_EventReceiverProc+0x61 [c:\moz_src\mozilla\xpcom\threads\plevent.c:1071 
ip=0x100cdd6f]
            {
                PREventQueue *queue = (PREventQueue *)lParam;
                queue->removeMsg = PR_FALSE;
     =>         PL_ProcessPendingEvents(queue);
                queue->removeMsg = PR_TRUE;
        #ifdef XP_OS2
                return MRFROMLONG(TRUE);
    ScrollDC+0x490       [C:\WINNT\SYSTEM32\user32.dll ip=0x77e12e98]
    ScrollDC+0x6d8       [C:\WINNT\SYSTEM32\user32.dll ip=0x77e130e0]
    DispatchMessageA+0xb [C:\WINNT\SYSTEM32\user32.dll ip=0x77e15824]

Comment 1

[Jerome Lacoste]

maybe 
Lines 561 -> 565 
// destructor
//
nsLDAPConnectionLoop::~nsLDAPConnectionLoop()
{
}

should be replaced  by

// destructor
//
nsLDAPConnectionLoop::~nsLDAPConnectionLoop()
{
  if (mLock) {
    PR_DestroyLock(mLock);
  }
}


??
Jerome

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Giving to leif.

Comment 3

[Leif Hedstrom]

Attachment: Memory leak fix

Comment 4

[Leif Hedstrom]

Mitesh - Can you review this please?

Comment 5

[Mitesh Shah]

Comment on attachment 53651 [details] [diff] [review]
Memory leak fix

looks good. r=mitesh

Comment 6

[David :Bienvenu]

Comment on attachment 53651 [details] [diff] [review]
Memory leak fix

sr=bienvenu

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

QA-->Myself.  I'm set up to verify this using Purify.

Comment 8

[Leif Hedstrom]

Checked in on trunk.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED.

I've filed 2 bugs, bug 106857 and bug 106858 for new leaks.