1031018 - Add Firefox Marketplace to tools menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Wil Clouser [:clouserw]]

On Fennec you can click Tools -> Apps to load an intermediary page about apps which points to marketplace.firefox.com.  We should do the same thing in the desktop browser.  Since we don't have an intermediary page currently, we could just load marketplace.firefox.com.

Comment 1

[Wil Clouser [:clouserw]]

The URL for this is https://marketplace.firefox.com/discovery/

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> The URL for this is https://marketplace.firefox.com/discovery/

I assume this page does appropriate locale detection automatically?

Comment 3

[Wil Clouser [:clouserw]]

yes

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Screenshot: https://cloudup.com/ciQfOr2C1tm

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8492422 [details] [diff] [review]
patch

Review of attachment 8492422 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, the short "Apps" string look weird to me but it could just be because I'm used to certain strings in that menu. I understand this matches Fennec so that's fine but if I had to pick another name I would choose "App Marketplace".

Comment 6

[Dão Gottwald [:dao]]

(In reply to Matthew N. [:MattN] from comment #5)
> Comment on attachment 8492422 [details] [diff] [review]
> patch
> 
> Review of attachment 8492422 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> FWIW, the short "Apps" string look weird to me but it could just be because
> I'm used to certain strings in that menu.

This seems particularly confusing because (1) all other "tools" are local ones, things that come built-in or that you've installed rather than gateways for discovering new stuff and (2) once you've installed apps from the marketplace, it makes even more sense to expect them to show up next to the other installed "tools".

Comment 7

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

The UI itself looks fine, but I'm not sure if that's the right solution to the problem.

Do we want to promote our marketplace? Then the tools menu is not a very effective choice since it is only visible by default on Mac and not very highly used in general.

Also, if we want to promote apps from the marketplace in the browser, we need to do a better job at explaining what will happen when you install an app and how you can access it afterwards.

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8492422 [details] [diff] [review]
patch

Preliminary ui-r- until we figure out the issues raised in comment 7.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to Philipp Sackl [:phlsa] from comment #7)
> Do we want to promote our marketplace?

Yes.

> Then the tools menu is not a very
> effective choice since it is only visible by default on Mac and not very
> highly used in general.

I agree, but it's not all we're doing. We're trying to be consistent with Add-ons in the general sense, so we're also going to fix bug 1031019.

> Also, if we want to promote apps from the marketplace in the browser, we
> need to do a better job at explaining what will happen when you install an
> app and how you can access it afterwards.

This is reasonable, but shouldn't the Marketplace itself do this?

Comment 10

[Caitlin Galimidi [:c8o]]

Let's definitely do a great job explaining what happens when you install an app.
MDN has made a good start: https://developer.mozilla.org/en-US/Marketplace/Options/Open_web_apps_for_desktop 

Where should some consumer info be placed?

FYI - Desktop apps already install, and are managed in the same way apps are managed on a desktop machine.
See this video for questions: https://www.youtube.com/watch?v=dO-l5odB4hM

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8492422 [details] [diff] [review]
patch

Asking for reconsideration given comment 9

Comment 12

[:Gavin Sharp [email: [e-mail]]]

I went ahead and pushed this as-is. Philipp, please do let me know if you want me to follow-up and adjust this at all.

https://hg.mozilla.org/integration/fx-team/rev/39ee3eba02cf

Comment 13

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8492422 [details] [diff] [review]
patch

After-the-fact-ui-r+ :)

I'll file some bugs for the marketplace team to make it a little more desktop-friendly.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39ee3eba02cf

Comment 15

[Bogdan Maris, Desktop Test Engineering]

I did some exploratory testing around this implementation and did not found any issues. I tested using latest Nightly on Windows 7 64bit, Ubuntu 14.04 32bit and Mac OS X 10.9.5. 
Marking this as verified based on my testing.

Comment 16

[Matthew N. [:MattN]]

Release Note Request (optional, but appreciated)
[Why is this notable]: With bug 1031019, the Firefox Marketplace is promoted in desktop Firefox
[Suggested wording]: Access the Firefox Marketplace from the Tools menu and optional toolbar button.
[Links (documentation, blog post, etc)]: https://marketplace.firefox.com/discovery/

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

noted from bug 1031019, no need to do it twice.