Closed Bug 1031025 Opened 6 years ago Closed 6 years ago

Update .hgignore to ignore Loop unit test files

Categories

(Core :: General, defect)

33 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: abr, Assigned: abr)

Details

Attachments

(1 file)

Currently, running the Loop marionette tests manually results in a substantial chunk of node module stuff to be downloaded into the tree. We should tell hg to ignore:

browser/components/loop/standalone/content/config.js
browser/components/loop/standalone/node_modules (and its subfiles)
Summary: Update .hgignore to ignore Loop marionette test files → Update .hgignore to ignore Loop unit test files
Attachment #8447217 - Flags: review?(jorendorff)
Comment on attachment 8447217 [details] [diff] [review]
Add generated/downloaded Loop unit test files

Review of attachment 8447217 [details] [diff] [review]:
-----------------------------------------------------------------

OK, there are already 74 lines of random debris in here, what's another 2.

I don't know a lot about node. Based on what I do know, ^.../node_modules/ is definitely OK to ignore; I'm assuming the other one is also OK.

In general, it's better to put stuff like this in the objdir. That way, if, say, different build configurations use different modules or whatever, as long as you use separate objdirs, they won't collide. I'm assuming we don't care about that here.

::: .hgignore
@@ +72,5 @@
>  GSYMS
>  GPATH
> +
> +# Unit tests for Loop
> +^browser/components/loop/standalone/content/config.js$

Backslash before the dot, if you don't mind: config\.js$

It's a regexp.
Attachment #8447217 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/aad532ce08e2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.