1031105 - [Collection] Edit mode can be triggered on unbookmarked e.me apps if another e.me app is added twice to the top of that Smart Collection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Open a Smart Collection
2. Add a e.me app to the homesceen.
3. Go to the homescreen and add this app *twice* to a Smart Collection
4. Enter that Smart Collection
5. Move the app you just added
6. Long press an unbookmarked e.me app

Expected result
Context menu should be opened.

Actual result
Hello Edit mode! See video for details.

Additional notes
STR appear to be reduced at their maximum.

This issue can also be hit by replacing step 3 by:
- 3. Add this app to the top of the homescreen
- 3bis. Go to the homescreen and add this app *once* to the Smart Collection where it comes from.

Video link: http://mzl.la/1nJjAdH

Comment 1

[Johan Lorenzo [:jlorenzo]]

This issue seems to be hard to hit, but I came accross it by just playing around with the feature. 

Furthermore, the impact of that bug is big. If you move an unbookmarked icon to the top of the collection, you exit it and you come back into it; the Smart Collection doesn't load anymore, even after a reboot.

Comment 2

[Kevin Grandon :kgrandon]

Thank you for the video Johan, that was really helpful.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Ran - another review your way when you get a chance, thanks.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

I think that in the future we should change this to bring the already pinned item to the top of the pinned list so that the user action reflects in the Collection icon.

Comment 5

[Kevin Grandon :kgrandon]

Sounds like we could definitely do that in the future. Landed: https://github.com/mozilla-b2g/gaia/commit/c2d6bcfd499b09c93f4dd2a1f87a166b302d10ee

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/4b77c51fc6cda67a759a23b54de5e9a91cf439f7

Comment 7

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame v2.1&2.0.
See attachment: verified_v2.1_1.mp4 and verified_v2.1_2.mp4.
Reproduce rate: 0/5

STR:
1. Open a Smart Collection.
2. Add a e.me app to the homesceen.
3. Go to the homescreen and add this app *twice* to other Smart Collection(or the Smart Collection where it comes from).
4. Open the Smart Collection.
5. Long tap this app and tap "Done"(or tap "X" to move this app you just added).
6. Long tap an unbookmarked e.me app(or the app you added and then moved in step 5).
**The "Add to Home Screen" and "Add to top of collection" menu will pop up.

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034405
FW-Date         Mon Dec  1 03:44:15 EST 2014
Bootloader      L1TC00011880

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034308
FW-Date         Mon Dec  1 03:43:18 EST 2014
Bootloader      L1TC00011880

Comment 8

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1_1.MP4

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1_2.MP4