Closed Bug 1031136 Opened 5 years ago Closed 5 years ago

[Calendar] "All day" overlaps in month view for long localizations

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v1.4 unaffected, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S6 (18july)
blocking-b2g 2.0+
Tracking Status
b2g-v1.4 --- unaffected
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: flod, Assigned: mmedeiros)

References

Details

(Keywords: regression)

Attachments

(4 files)

Label localizability was fixed in bug 1030552, but we still have a problem when the localization is long, and label overlaps with the event name.

A screenshot of the issue is available here
https://bugzilla.mozilla.org/attachment.cgi?id=8446402
Assignee: nobody → mmedeiros
Blocks: 1027360
blocking-b2g: --- → 2.0?
Target Milestone: --- → 2.0 S5 (4july)
Peko, do you have any suggestions? see all the strings used for "all day" here: http://transvision.mozfr.org/string/?entity=apps/calendar/calendar.properties:hour-allday&repo=gaia

many locales fit on a single line, these are just a sample of the "edge cases".

PS: we can NOT change the column width dynamically based on the locale.
PPS: I used `#months-day-view .event-time .all-day { white-space:normal; line-height:1.4; width:7rem; }`
Flags: needinfo?(pchen)
Hi Miller,

Visually I am ok with breaking words into two line but depends on localization.
thank you!!

Peko
Flags: needinfo?(pchen)
blocking-b2g: 2.0? → 2.0+
Keywords: regression
Comment on attachment 8447553 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21135

LGTM thanks!
Attachment #8447553 - Flags: review?(gaye) → review+
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
landed on master: https://github.com/mozilla-b2g/gaia/commit/65ed9ce115500813bbc3f7ef48d266fa5d5f0698
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Hi Francesco,
Do you mean when the string "All days" is translated very long in some language, the string shouldn't be displayed in two lines?
Please see if the attachment "001.png" is fial?
Flags: needinfo?(francesco.lodolo)
Attached image 001.jpg
Yes. white-space was changed to normal, which means the text will wrap on 2 lines if it's too long instead of overlapping.
Flags: needinfo?(francesco.lodolo)
This issue has been verified successfully on Flame2.0&2.1
Verify video:"verify_1031136.mp4".

Flame2.0 build
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880
Status: RESOLVED → VERIFIED
Attached video verify_1031136.mp4
You need to log in before you can comment on or make changes to this bug.