1031136 - [Calendar] "All day" overlaps in month view for long localizations

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Francesco Lodolo [:flod]]

Label localizability was fixed in bug 1030552, but we still have a problem when the localization is long, and label overlaps with the event name.

A screenshot of the issue is available here
https://bugzilla.mozilla.org/attachment.cgi?id=8446402

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: allday_l10n_line_break.png

Peko, do you have any suggestions? see all the strings used for "all day" here: http://transvision.mozfr.org/string/?entity=apps/calendar/calendar.properties:hour-allday&repo=gaia

many locales fit on a single line, these are just a sample of the "edge cases".

PS: we can NOT change the column width dynamically based on the locale.
PPS: I used `#months-day-view .event-time .all-day { white-space:normal; line-height:1.4; width:7rem; }`

Comment 2

[Peko Chen [:pekochen]]

Hi Miller,

Visually I am ok with breaking words into two line but depends on localization.
thank you!!

Peko

Comment 3

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21135

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8447553 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21135

LGTM thanks!

Comment 5

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/65ed9ce115500813bbc3f7ef48d266fa5d5f0698

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/d9b225fd156b16adabcf459275b52674dde517cc

Comment 7

[SandKing]

Hi Francesco,
Do you mean when the string "All days" is translated very long in some language, the string shouldn't be displayed in two lines?
Please see if the attachment "001.png" is fial?

Comment 8

[SandKing]

Attachment: 001.jpg

Comment 9

[Francesco Lodolo [:flod]]

Yes. white-space was changed to normal, which means the text will wrap on 2 lines if it's too long instead of overlapping.

Comment 10

[SandKing]

This issue has been verified successfully on Flame2.0&2.1
Verify video:"verify_1031136.mp4".

Flame2.0 build
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 11

[SandKing]

Attachment: verify_1031136.mp4