Closed Bug 1031166 Opened 6 years ago Closed 6 years ago

Fix non-unified OS X build's warnings-as-errors in toolkit/components/places

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

When building with these mozconfig settings using clang on OS X:

ac_add_options --disable-unified-compilation
ac_add_options --enable-warnings-as-errors

I hit the following warnings-as-error build error:

> toolkit/components/places/nsNavHistory.cpp:105:22: error: unused variable 'USECS_PER_DAY' [-Werror,-Wunused-const-variable]
Attachment #8446989 - Flags: review?(mak77)
Comment on attachment 8446989 [details] [diff] [review]
fix-places-non-unified-build.patch

Review of attachment 8446989 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8446989 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/c09a5006b5f0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.