1031185 - [Bluetooth] Port bug 1027030 to bluetooth2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1031185: Wrap Bluedroid interfaces in classes

No functional changes from bug 1027030.
No rebase changes from bug 1027030.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1031185: Convert Bluetooth to use Bluedroid wrappers

No functional changes since bug 1027030.
Simple rebase changes since bug 1027030.

Comment 3

[Ben Tian (inactive)]

Comment on attachment 8447023 [details] [diff] [review]
[01] Bug 1031185: Wrap Bluedroid interfaces in classes

Review of attachment 8447023 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Thanks.

::: dom/bluetooth2/bluedroid/BluetoothInterface.cpp
@@ +364,5 @@
> +#else
> +  return BT_STATUS_UNSUPPORTED;
> +#endif
> +}
> +#endif

nit: Add comment to match #if.

  #endif // #if ANDROID_VERSION >= 18

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8447024 [details] [diff] [review]
[02] Bug 1031185: Convert Bluetooth to use Bluedroid wrappers

Review of attachment 8447024 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed. Thanks.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +21,4 @@
>  #include "BluetoothA2dpManager.h"
>  #include "BluetoothHfpManager.h"
>  #include "BluetoothOppManager.h"
> +#include "BluetoothInterface.h"

nit: alphabetical order.

::: dom/bluetooth2/bluedroid/BluetoothSocket.cpp
@@ +10,5 @@
>  #include <sys/socket.h>
>  
>  #include "base/message_loop.h"
>  #include "BluetoothSocketObserver.h"
> +#include "BluetoothInterface.h"

Ditto.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1031185: Wrap Bluedroid interfaces in classes (v2)

Changes since v1:

  - comment #endif statement

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1031185: Convert Bluetooth to use Bluedroid wrappers (v2)

Changes since v1:

  - sort include statements alphabetically

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Ben!

https://hg.mozilla.org/integration/b2g-inbound/rev/f638a16ddbf7
https://hg.mozilla.org/integration/b2g-inbound/rev/91411f5b8574

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=91411f5b8574

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f638a16ddbf7
https://hg.mozilla.org/mozilla-central/rev/91411f5b8574