Closed
Bug 1031254
Opened 10 years ago
Closed 10 years ago
[Vertical Homescreen] Add configure button in context menu
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 wontfix, b2g-v2.1 verified)
VERIFIED
FIXED
2.0 S6 (18july)
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [systemsfe])
Attachments
(4 files)
I wanted to open this bug just because of I would like to show a new option like "Settings or Configure" in the contextmenu once that the pinch-to-zoom was removed from 2.0.
Could we have a new option in the context menu like:
----
Settings or Configure...
----
Change Wallpaper
----
Add Smart Collections
----
Cancel
When an user click on this new option an activity would be performed in order to show the setting app in the homescreen panel thought
Is a good idea? or maybe an stupid thing XD
Assignee | ||
Updated•10 years ago
|
Blocks: vertical-home-next
Assignee | ||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 1•10 years ago
|
||
What do you think? Many thanks
Flags: needinfo?(jsavory)
Flags: needinfo?(fdjabri)
Updated•10 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Comment 2•10 years ago
|
||
That sounds like a great idea to me. What do you think Jacqueline?
Flags: needinfo?(fdjabri)
Comment 3•10 years ago
|
||
I think this is a great idea as well, perhaps "Homescreen Settings" would work as the option. However I don't think we can add anymore strings to 2.0. Cristian do you know if there is an existing string that we can use in this situation?
Flags: needinfo?(jsavory) → needinfo?(crdlc)
Assignee | ||
Comment 4•10 years ago
|
||
Sadly I don't see any string related to "Homescreen Settings"
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/locales/homescreen.en-US.properties
(In reply to jsavory from comment #3)
> I think this is a great idea as well, perhaps "Homescreen Settings" would
> work as the option. However I don't think we can add anymore strings to 2.0.
> Cristian do you know if there is an existing string that we can use in this
> situation?
Flags: needinfo?(crdlc) → needinfo?(jsavory)
Assignee | ||
Comment 5•10 years ago
|
||
uff I added a wrong link. This is the locales that the vertical homescreen has right now
https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/locales/homescreen.en-US.properties
Assignee | ||
Comment 6•10 years ago
|
||
Just in case you want to test the feature in the device
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
I think that this looks great, but you're right, I don't think we can use any of the strings listed... perhaps we can include this for 2.1?
Flags: needinfo?(jsavory)
Assignee | ||
Comment 9•10 years ago
|
||
ok for 2.1
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8447853 [details]
Github pull request
thanks Kevin
Attachment #8447853 -
Flags: review?(kgrandon)
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.0:
--- → wontfix
status-b2g-v2.1:
--- → affected
Assignee | ||
Comment 11•10 years ago
|
||
Ready for 2.1
(In reply to jsavory from comment #8)
> I think that this looks great, but you're right, I don't think we can use
> any of the strings listed... perhaps we can include this for 2.1?
Comment 12•10 years ago
|
||
Comment on attachment 8447854 [details]
Screenshots of the implementation
Let's ask for a UI review from Jacqueline first..
Attachment #8447854 -
Flags: ui-review?(jsavory)
Updated•10 years ago
|
Attachment #8447853 -
Flags: review?(kgrandon) → review+
Comment 13•10 years ago
|
||
Comment on attachment 8447854 [details]
Screenshots of the implementation
This looks like it works for me.
Attachment #8447854 -
Flags: ui-review?(jsavory) → ui-review+
Assignee | ||
Comment 14•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Updated•10 years ago
|
Target Milestone: --- → 2.0 S6 (18july)
Updated•10 years ago
|
Comment 15•10 years ago
|
||
This issue has been successfully verified on Flame 2.1.
See attachments: verified_v2.1_1.png and verified_v2.1_2.png.
Reproduce rate: 0/5
Flame 2.1 build:
Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID 20141201001201
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141201.034405
FW-Date Mon Dec 1 03:44:15 EST 2014
Bootloader L1TC00011880
Status: RESOLVED → VERIFIED
Comment 16•10 years ago
|
||
Comment 17•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•