Closed
Bug 1031258
Opened 10 years ago
Closed 10 years ago
Smart collection view does not use APZ
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Firefox OS Graveyard
Gaia::Everything.me
Tracking
(tracking-b2g:backlog, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
tracking-b2g | backlog |
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
(Keywords: perf, Whiteboard: [systemsfe])
Attachments
(1 file)
3.86 KB,
patch
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Diff | Splinter Review |
It seems like the html/css code is formatted in such a way that APZ fails.
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=d5e095f0638c29ce4dfa787f93d208a5da64b0fc
Assignee: nobody → 21
Attachment #8447117 -
Flags: review?(kgrandon)
Updated•10 years ago
|
Blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Component: Gaia::Homescreen → Gaia::Everything.me
Whiteboard: [systemsfe]
Updated•10 years ago
|
blocking-b2g: 2.0? → backlog
Updated•10 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking-]
Comment 2•10 years ago
|
||
Comment on attachment 8447117 [details] [diff] [review] bug1031258.patch Review of attachment 8447117 [details] [diff] [review]: ----------------------------------------------------------------- Scrolling is sooo much better in collections with this. Thanks! ::: apps/collection/view.html @@ +74,5 @@ > </header> > </section> > > + <div id="content-background-image"> > + <div id="content-background-color"> nit: can we rename this to something like: content-background-overlay? At first glance I assumed that this was for the background-color property, and it seemed weird being on top of the image. I'd recommend a rename to potentially save people the same confusion I faced, but would not block the review on it.
Attachment #8447117 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #2) > Comment on attachment 8447117 [details] [diff] [review] > bug1031258.patch > > Review of attachment 8447117 [details] [diff] [review]: > ----------------------------------------------------------------- > > Scrolling is sooo much better in collections with this. Thanks! > > ::: apps/collection/view.html > @@ +74,5 @@ > > </header> > > </section> > > > > + <div id="content-background-image"> > > + <div id="content-background-color"> > > nit: can we rename this to something like: content-background-overlay? > > At first glance I assumed that this was for the background-color property, > and it seemed weird being on top of the image. I'd recommend a rename to > potentially save people the same confusion I faced, but would not block the > review on it. I will fix the name before landing (already in my PR).
Assignee | ||
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/e120a13b630f44881fbf7a81cae769f430227fec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
Thanks guys. APZ is looking good.
I am a bit uncomfortable with the nested structure of the DOM. When everything is position absolute, I guess we can have the bg as a separate element to the content. Something like:
> <header ... >
> <section id="edit-header" ... >
> <div id="background"></div> // applies image and pseudo element acts as overlay
> <div id="content" ... >
Lmk if it's relevant in your opinion.
Comment 6•10 years ago
|
||
Comment on attachment 8447117 [details] [diff] [review] bug1031258.patch This is a small patch that greatly improves scroll performance in collections. It is needed for the vertical homescreen.
Attachment #8447117 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
Attachment #8447117 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 7•10 years ago
|
||
2.0: https://github.com/mozilla-b2g/gaia/commit/bb9020962a11bf16b52b31899ac71f8a887b6106
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
Updated•9 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•