1031320 - [Search experiment] Display notification UI for the correct groups

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1029792 +++

This bug is about injecting the notification UI properly on all windows, track the amount of times it has been displayed, track if the user clicked on X/Learn More to stop displaying it, and so on.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Note: the same popup element is used for the searchbar and web content. In order to make it not show for content, we will need to use this snippet somewhere:

> let popup = document.getElementById("PopupAutoComplete");
> let searchbar = document.getElementById("searchbar");
> popup.addEventListener("popupshowing", function(event) {
>   if (popup.mInput == searchbar.textbox) {
>     // this is a search from the searchbar, unhide the footer
>   }
> }, false);

Comment 2

[Marco Mucci [:MarcoM]]

Hi Blake, can you provide a point estimate and if this bug should be marked as [qa+] or [qa-]

Comment 3

[Blake Winton (:bwinton) (:☕️)]

I'm going with a 5, because I'm not sure how we're going to log the info we're tracking, and I'm also not sure what the full set of info we'll be collecting is.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

From Bug 1029189:
 
> Some additional notes:
> - This should be shown only in the first session after the switch, but for a
> maximum of five searches

Philipp, are you sure you want to limit this for the first session after the switch, and not just limit it for five searches, independent of how many sessions that takes to reach?

Comment 5

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Felipe Gomes from comment #1)
> Note: the same popup element is used for the searchbar and web content. In
> order to make it not show for content, we will need to use this snippet
> somewhere:

I included this in https://hg.mozilla.org/users/felipc_gmail.com/search-experiment/rev/f77bc56247fa

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Felipe Gomes from comment #4)
> From Bug 1029189:
>  
> > Some additional notes:
> > - This should be shown only in the first session after the switch, but for a
> > maximum of five searches
> 
> Philipp, are you sure you want to limit this for the first session after the
> switch, and not just limit it for five searches, independent of how many
> sessions that takes to reach?

Good point! Thinking about this again, I'd change it even further:
- Show it a minimum of 5 times (regardless of sessions)
- Show it a minimum of 1 session (even if the user has seen it more than 5 times)
- Clicking the close button or changing the search provider hides it immediately

That way we prevent the case where someone would like to act on it *next time*, but seconds later the notification is gone.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

The work for this is done, but the code review is happening in bug 1029818.
So I'm going to close this, and do any further work over there.

Comment 8

[Marco Mucci [:MarcoM]]

(In reply to Blake Winton (:bwinton) from comment #7)
> The work for this is done, but the code review is happening in bug 1029818.
> So I'm going to close this, and do any further work over there.

Hi Blake, is the [qa+] still relevant then?

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Hmm.  Good question.  Let's say "no", and do the testing over there, too.
(Actually, that bug seems to mostly be about testing.)