1031500 - Expose graphic Buffer to MediaCodec

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

+++ This bug was initially created as a clone of Bug #1009410 +++

WebRTC OMX H.264 decode ends up blocked on buffers; as a near-term workaround, increase the number of buffers for WebRTC.  Note that the codec can only do HVGA @30fps @700Kbps when used for encode and decode at once, so that limits the memory hit.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Increase number of buffers for webrtc OMX H.264 decode

jhlin's patch from bug 1009410

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8447381 [details] [diff] [review]
Increase number of buffers for webrtc OMX H.264 decode

Review of attachment 8447381 [details] [diff] [review]:
-----------------------------------------------------------------

Rview+ if the hardcoded "10" defined in another place. Hard-code a number directly to a function's argument is not good.

Comment 3

[Florian Bender]

(In reply to Randell Jesup [:jesup] from comment #0)
> WebRTC OMX H.264 decode ends up blocked on buffers; as a near-term
> workaround, increase the number of buffers for WebRTC.  

Please file a bug for undoing that workaround (once this lands at the latest).

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/febfad44b731

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/febfad44b731

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8447381 [details] [diff] [review]
Increase number of buffers for webrtc OMX H.264 decode

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Jerking/low-frame-rate in B2G Webrtc with HW H.264 (8x10/Flame)

[Describe test coverage new/current, TBPL]: On M-c since last week

[Risks and why]: Only risk is memory use; the extra buffers are only used in WebRTC H.264 OMX calls

[String/UUID change made/needed]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8447381 [details] [diff] [review]
Increase number of buffers for webrtc OMX H.264 decode

2.0+ have auto-approval for Aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75f0e9ea8629

Comment 9

[Blake Wu [:bwu][:blakewu]]

(In reply to Florian Bender from comment #3)
> (In reply to Randell Jesup [:jesup] from comment #0)
> > WebRTC OMX H.264 decode ends up blocked on buffers; as a near-term
> > workaround, increase the number of buffers for WebRTC.  
> 
> Please file a bug for undoing that workaround (once this lands at the
> latest).

It should be bug 1009410.