Closed
Bug 1031967
Opened 11 years ago
Closed 11 years ago
make mozilla::css::Loader cycle collected
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: heycam, Assigned: heycam)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
6.48 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I want to add an CSS loader observer that is a cycle collected object that has a strong reference back to the document. We need to traverse/unlink the observer array elements for this to avoid leaking.
|
Assignee | |
Comment 1•11 years ago
|
||
Or let me know if the Loader object itself should be a cycle collected object.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8447793 [details] [diff] [review]
patch
I think cycle-collecting the CSSLoader is the way to go. It'll make the code look much more normal.
Attachment #8447793 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8447793 -
Attachment is obsolete: true
Attachment #8448448 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Summary: cycle collect CSS loader's observer array → make mozilla::css::Loader cycle collected
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8448448 [details] [diff] [review]
patch v2
r=me
Attachment #8448448 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1046534
You need to log in
before you can comment on or make changes to this bug.
Description
•