Closed Bug 1031978 Opened 6 years ago Closed 6 years ago

Suppress -Wmismatched-tags clang warnings in third-party code: libstagefright

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1026535 reenabled clang's -Wmismatched-tags warning about mixing forward declarations using class and struct. libstagefright already suppresses these C4099 warnings for MSVC, where (unlikely clang and gcc, AFAIK) class and struct can have different ABIs.

> media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:28:1 [-Wmismatched-tags] class 'String8' was previously declared as a struct
> media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:30:1 [-Wmismatched-tags] 'DataSource' defined as a class here but previously declared as a struct
> media/libstagefright/frameworks/av/include/media/stagefright/MediaSource.h:32:1 [-Wmismatched-tags] 'MediaSource' defined as a struct here but previously declared as a class
> media/libstagefright/frameworks/av/include/media/stagefright/Utils.h:44:1 [-Wmismatched-tags] struct 'MetaData' was previously declared as a class
> media/libstagefright/frameworks/av/media/libstagefright/include/SampleIterator.h:24:1 [-Wmismatched-tags] struct 'SampleTable' was previously declared as a class
> media/libstagefright/system/core/include/utils/String8.h:41:1 [-Wmismatched-tags] 'String8' defined as a class here but previously declared as a struct
Attachment #8447804 - Flags: review?(cajbir.bugzilla)
Attachment #8447804 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/bc31e6afdeb3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.