Suppress -Wsign-compare warning in third-party code: expat XML parser

RESOLVED FIXED in Firefox 33

Status

()

Core
XML
P4
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox32 wontfix, firefox33 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8447806 [details] [diff] [review]
suppress-expat-Wsign-compare.patch

Suppress the one warning reported by clang and gcc in the third-party parser/expat code:

> parser/expat/lib/xmlparse.c:6271:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'

I don't think we should mark parser/expat as FAIL_ON_WARNINGS because it is third-party code, not Mozilla code.
Attachment #8447806 - Flags: review?(peterv)
Can we just add |(int)(...)| to INIT_BLOCK_SIZE? We've already modified it's definition in our tree anyway.
(Assignee)

Comment 2

4 years ago
Created attachment 8449209 [details] [diff] [review]
suppress-Wsign-compare-warning-v2.patch

patch v2: Wrap INIT_BLOCK_SIZE definition in ((int)(...)) type cast.
Attachment #8447806 - Attachment is obsolete: true
Attachment #8447806 - Flags: review?(peterv)
Attachment #8449209 - Flags: review?(peterv)
Attachment #8449209 - Flags: review?(peterv) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4716807bc66b
status-firefox32: --- → wontfix
status-firefox33: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/4716807bc66b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.