Closed
Bug 1032121
Opened 11 years ago
Closed 11 years ago
Remove leftover code from the removal of automatic content type handlers
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S5 (4july)
People
(Reporter: amac, Assigned: amac)
References
Details
Attachments
(1 file)
2.25 KB,
patch
|
fabrice
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1009781 removed the activity -> Content type handler mapping but it left some code behind. That code is showing the error:
"types.forEach is not a function" {file: "resource://gre/modules/ActivitiesService.jsm" line: 428}]
and generating an array that's then just throw out in the best case.
Assignee | ||
Comment 1•11 years ago
|
||
Although I don't expect any problems since what's removed just created an array that wasn't used anywhere, try run is at:
https://tbpl.mozilla.org/?tree=Try&rev=6b2cda0423ae
Attachment #8447913 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #8447913 -
Flags: review?(fabrice) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 2•11 years ago
|
||
Keywords: checkin-needed
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8447913 [details] [diff] [review]
V1. Remove code that should be dead
Approval Request Comment
[Feature/regressing bug #]: Bug 1009781
[User impact if declined]: Unknown, it is failing on 2.0 and when it fails activities won't be completely registered or unregistered.
[Describe test coverage new/current, TBPL]: There are no new tests, this just removes leftover code from a previous change.
[Risks and why]: Very low, it just remove dead code (or code that should be dead)
[String/UUID change made/needed]: None
Attachment #8447913 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8447913 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•11 years ago
|
||
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
Target Milestone: --- → 2.0 S5 (4july)
You need to log in
before you can comment on or make changes to this bug.
Description
•