Remove leftover code from the removal of automatic content type handlers

RESOLVED FIXED in Firefox 32

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: amac, Assigned: amac)

Tracking

unspecified
2.0 S5 (4july)
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

Bug 1009781 removed the activity -> Content type handler mapping but it left some code behind. That code is showing the error:

 "types.forEach is not a function" {file: "resource://gre/modules/ActivitiesService.jsm" line: 428}]

and generating an array that's then just throw out in the best case.
Although I don't expect any problems since what's removed just created an array that wasn't used anywhere, try run is at:
https://tbpl.mozilla.org/?tree=Try&rev=6b2cda0423ae
Attachment #8447913 - Flags: review?(fabrice)
Attachment #8447913 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/c3b6129862d8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8447913 [details] [diff] [review]
V1. Remove code that should be dead

Approval Request Comment
[Feature/regressing bug #]: Bug 1009781 
[User impact if declined]: Unknown, it is failing on 2.0 and when it fails activities won't be completely registered or unregistered.
[Describe test coverage new/current, TBPL]: There are no new tests, this just removes leftover code from a previous change.
[Risks and why]: Very low, it just remove dead code (or code that should be dead)
[String/UUID change made/needed]: None
Attachment #8447913 - Flags: approval-mozilla-aurora?
Attachment #8447913 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.