1032124 - Cloned object (using nested use element) not updated when manipulated through JavaScript

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Pim Klanke]

Attachment: bugreport.svg

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193813

Steps to reproduce:

Open attached SVG in firefox; Two red lines are shown.
Perform onClick event on SVG to manipulate the line color.


Actual results:

The first line is updated to the correct color (lime). The second line does not change color.


Expected results:

Since both elements refer to the same line element, both lines should have changed color. The second line, which is in fact a reference to a reference to the line element, is not updated.

This might be flagged as a duplicate of #537987, but since no JavaScript and only a single refrence is used in its attached test case, I filed this as a new bug.

Comment 1

[Robert Longson [:longsonr]]

It's not really related to bug 537987 but it is pretty similar to bug 467498

Comment 2

[Paul LeBeau]

This also popped up on Stack Overflow today. Except in this case it is use->use->element, rather than use->symbol->use->element.

https://stackoverflow.com/questions/53744396/vue-svg-element-doesnt-updates-in-firefox/53753302

I've created a small test case to replicate it: https://jsfiddle.net/qz8aLtxk/

<svg>
  <defs>
    <rect id="rect" width="140" height="150" fill="red"/>
  </defs>
  <use id="use" xlink:href="#rect"/>
  <use id="use2" xlink:href="#use" x="150"/>
</svg>

<button>Toggle green</button>


.green {
  fill: green;
}


document.querySelector("button").addEventListener("click", function() {
  document.getElementById("rect").classList.toggle("green");
})

Comment 3

[violet.bugreport]

Attachment: Bug 1032124 - Use the referenced element to check whether to ignore a mutation event

If <use> element u1 links to another <use> element u2,
and u2 links to u3, now u3 is updated, then u2 will
be notified by mutation observer to trigger a reclone.
But the reclone on u2 won't send any notification to u1,
thus u1 is not properly synced with u3.

We should record all cloned places of an <use> element, then trigger
reclone of those cloned places when itself is recloned.

Comment 4

[violet.bugreport]

Robert, would you take a look at this patch? Just in case that you missed the review email. Thanks.

Comment 5

[Robert Longson [:longsonr]]

I was waiting till you fixed the review comments from emilio. I think it's likely fine once you've done that though.

Comment 6

[violet.bugreport]

(In reply to Robert Longson [:longsonr] from comment #5)

I was waiting till you fixed the review comments from emilio. I think it's likely fine once you've done that though.

Actually I've already done that a few days ago. The patch was completely rewritten during a revision because a hidden root cause was discovered after discussing with emilio. Thus most of the comments on the previous revisions become obsolete (the original changes were reverted)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96b0fd9c79cd
Use the referenced element to check whether to ignore a mutation event r=emilio,longsonr

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17330 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/96b0fd9c79cd

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged