Closed Bug 1032127 Opened 6 years ago Closed 6 years ago

tooltool upload should set file permissions to world readable

Categories

(Release Engineering :: General, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: sbruno)

Details

Attachments

(1 file)

Did my first upload with https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool#How_to_upload_to_tooltool, and I hadn't paid any attention to the permissions set on the stage files. They happened to be 640, which wasn't changed by the upload, so the files weren't visible to Apache.

How about we enforce 644, or at least a=r.
Assignee: nobody → sbruno
After copying, explicitly sets permissions to 644
Attachment #8452997 - Flags: review?(rail)
Comment on attachment 8452997 [details] [diff] [review]
tooltool_01.patch

Review of attachment 8452997 [details] [diff] [review]:
-----------------------------------------------------------------

::: sync.py
@@ +240,5 @@
>                              try:
> +                                target_filename = os.path.join(destination, "temp%s" % digest)
> +                                shutil.copy(digest_path, target_filename)
> +                                # 420 is decimal for 644 (octal), sets permission to -rw-r--r-- to make sure the file is readable
> +                                os.chmod(target_filename, 420)

Can you replace 420 with 0644 (with leading zero) please. It's more readable. The comments would look simpler in this case. :)

Otherwise looks good to me.
Attachment #8452997 - Flags: review?(rail) → review+
Great! I did not figure out I could just put 0644. Thanks!
Deployed on relengwebadm.private.scl3.mozilla.com.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.