1032131 - [Homescreen] Statusbar is not opaque anymore when entering edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Seems like a regression from bug 1027990 where some renaming were not honored :)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1032131.patch

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8447914 [details] [diff] [review]
bug1032131.patch

Review of attachment 8447914 [details] [diff] [review]:
-----------------------------------------------------------------

Looks perfect, R+ while Kevin is sleeping :)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=0fbee6a8debd8c1031e3fed9ccc43d8064187492

Comment 4

[Jason Smith [:jsmith]]

Per a discussion with VD - all instances of a transparent status bar appearing when it shouldn't is a blocker for the 2.0 visual refresh.

Comment 5

[Kevin Grandon :kgrandon]

Thanks guys... I'll try to get around to writing some tests for this.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/2bc48b412321c5809c2ec33cc7a6c3cabcb3dd8d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/e39bcdf138b8c1bb69909237c30345e4141ed9ee