Closed Bug 1032152 Opened 9 years ago Closed 9 years ago
Job classification needs to be permitted for any logged in user, not just the sheriffs
Currently job classification has been limited to just those users with the sheriffing permissions set. However all developers need to be able to classify failures, since: a) They may wish to do so on their own try pushes b) Whilst most of the sheriffing is done by half a dozen people, their is a long tail of others that chip in occasionally or monitor their own project repos (and those people don't need to be able to perform the more admin-like tasks that I think the sheriffing permissions should be saved for). c) It doesn't seem very Mozilla to shut everyone out, including possible new-starting volunteer sheriffs. As such, we should either: 1) Allow failure classification to any logged in user (with logging to be able to tell if someone is causing mischief), or 2) Open up failure classification to anyone who has a vouched mozillians.org account (again, with logging).
(In reply to Ed Morley [:edmorley UTC+0] from comment #0) > As such, we should either: > 1) Allow failure classification to any logged in user (with logging to be > able to tell if someone is causing mischief), or > 2) Open up failure classification to anyone who has a vouched mozillians.org > account (again, with logging). I think we should go for #1 for now, to make this simpler to implement & so we don't prematurely optimise, given that we've had no issues with TBPL for several years, even though it doesn't even need a login at all.
Priority: -- → P1
Summary: Job classification needs to be permitted for most users, not just the sheriffs → Job classification needs to be permitted for any logged in user, not just the sheriffs
ok, will make this change.
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
I didn't see Ed's request for fields with fixes before pushing the change. I'll do those things in the future. But here's the commit SHA Github commit: fcbccc2f14bf9de2d1122942c3b92d0148676972 https://github.com/mozilla/treeherder-service/commit/fcbccc2f14bf9de2d1122942c3b92d0148676972
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Great - thank you :-)
You need to log in before you can comment on or make changes to this bug.