1032193 - Repo menu: Unchecking currently displayed repo doesn't update the page

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

1) In a private browsing window, open https://treeherder.mozilla.org
2) Open the repos menu, tick a repo that isn't checked at the moment (eg fx-team) and uncheck everything else (should just be the default repo, mozilla-inbound)
3) Close the repos menu

Actual:
The pinned repos list/repo switcher has updated, however the pushes/resultsets displayed belong to the previous (and now not listed in the switcher) repo. What makes this a bit more confusing, is that the colour of the other tab (in this case, fx-team) doesn't imply that the tab is inactive, so you don't know it doesn't yet have focus.

Expected:
Either we switch to the new repo (in this case, fx-team, or whichever comes first if several are checked), or else we make it clearer that the currently viewed page doesn't belong to any of the repos on the tab strip.

Comment 1

[Jonathan French (:jfrench)]

This is mentored and shows up in bugsahoy, so adding the suitable whiteboard value.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Disable checkbox for currently loaded repo

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Needinfo-ing Ed to make sure that this meets what he thinks should be done.

Comment 4

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-ui/commit/81897b573c4813101c22c354b5a788d66e005952

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dec02df9f744e766f8cc4a3358e167f227271c3c
Bug 1032193 - Disable the checkbox for the currently loaded repo

https://github.com/mozilla/treeherder/commit/2126b10c18a46fdc93f2667525056d645b35d76d
Merge pull request #159 from KWierso/1032193

Bug 1032193 - Disable the checkbox for the currently loaded repo