Closed Bug 1032193 Opened 8 years ago Closed 7 years ago

Repo menu: Unchecking currently displayed repo doesn't update the page

Categories

(Tree Management :: Treeherder, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: KWierso, Mentored)

References

()

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

1) In a private browsing window, open https://treeherder.mozilla.org
2) Open the repos menu, tick a repo that isn't checked at the moment (eg fx-team) and uncheck everything else (should just be the default repo, mozilla-inbound)
3) Close the repos menu

Actual:
The pinned repos list/repo switcher has updated, however the pushes/resultsets displayed belong to the previous (and now not listed in the switcher) repo. What makes this a bit more confusing, is that the colour of the other tab (in this case, fx-team) doesn't imply that the tab is inactive, so you don't know it doesn't yet have focus.

Expected:
Either we switch to the new repo (in this case, fx-team, or whichever comes first if several are checked), or else we make it clearer that the currently viewed page doesn't belong to any of the repos on the tab strip.
Priority: -- → P4
Blocks: 1053985
Mentor: cdawson
Summary: Unchecking currently displayed repo in the "Repos" menu doesn't update the page → Repo menu: Unchecking currently displayed repo doesn't update the page
This is mentored and shows up in bugsahoy, so adding the suitable whiteboard value.
Whiteboard: [good first bug]
Assignee: nobody → kwierso
Status: NEW → ASSIGNED
Attachment #8486765 - Flags: review?(cdawson)
Needinfo-ing Ed to make sure that this meets what he thinks should be done.
Flags: needinfo?(emorley)
Attachment #8486765 - Flags: review?(cdawson) → review+
Flags: needinfo?(emorley)
https://github.com/mozilla/treeherder-ui/commit/81897b573c4813101c22c354b5a788d66e005952
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dec02df9f744e766f8cc4a3358e167f227271c3c
Bug 1032193 - Disable the checkbox for the currently loaded repo

https://github.com/mozilla/treeherder/commit/2126b10c18a46fdc93f2667525056d645b35d76d
Merge pull request #159 from KWierso/1032193

Bug 1032193 - Disable the checkbox for the currently loaded repo
See Also: → 1408530
You need to log in before you can comment on or make changes to this bug.