Closed
Bug 1032280
Opened 11 years ago
Closed 11 years ago
settings permission seems unneeded
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: nicolas.golubovic+bugzilla, Unassigned)
References
Details
(Whiteboard: [priority])
The settings permission is requested in the manifest file [1] but the navigator.mozSettings API does not seem to be used in the app.
[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/manifest.webapp#L16
|
||
Comment 1•11 years ago
|
||
Gareth, can you evaluate if we can reduce the permissions here?
Flags: needinfo?(gaye)
Whiteboard: [priority]
|
||
Comment 3•11 years ago
|
||
NB: It used to be needed for l10n language change notifications. I think this went native recently and so no longer matters, but just want to call that out since I know I had forgotten about that for email.
|
||
Comment 4•11 years ago
|
||
Isn't this a good first bug? What do you think, Gareth?
Flags: needinfo?(gaye)
|
|
||
Comment 5•11 years ago
|
||
not a good first bug.. nowadays we do need the settings permission (readonly) because of `mozHour12` (/shared/js/date_time_helper.js)
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(gaye)
Resolution: --- → WONTFIX
|
|
||
Comment 6•11 years ago
|
||
You can scope the permission setting down to just be for mozHour12 or whatever you need though. You don't need wide open settings API access.
You need to log in
before you can comment on or make changes to this bug.
Description
•