Closed Bug 1032344 Opened 10 years ago Closed 9 years ago

Make some timeout related stuff inner window only

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1182316

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
      No description provided.
Attachment #8448148 - Flags: review?(bzbarsky)
Comment on attachment 8448148 [details] [diff] [review]
Patch

r=me
Attachment #8448148 - Flags: review?(bzbarsky) → review+
Comment on attachment 8448148 [details] [diff] [review]
Patch

Review of attachment 8448148 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +7257,5 @@
>  
>  void
>  nsGlobalWindow::ClearTimeout(int32_t aHandle, ErrorResult& aError)
>  {
> +  FORWARD_TO_INNER_OR_THROW(ClearTimeout, (aHandle, aError), aError, );

Shouldn't we be doing this in the XPCOM version of this function? Who else would call this with an outer?
Flags: needinfo?(khuey)
I think the XPCOM versions might be dead.
Flags: needinfo?(khuey)
Then why isn't that just asserting instead of forwarding? Again, who would call this with an outer?
Can we assume that every WebIDL entry point on Window is only called on an inner?
Flags: needinfo?(peterv)
From the bindings, anyways.  Obviously nothing stops someone else from calling the C++ function manually.
From the bindings, yes, you can.
Flags: needinfo?(peterv)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: