1032344 - Make some timeout related stuff inner window only

Status: RESOLVED DUPLICATE of bug 1182316

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8448148 [details] [diff] [review]
Patch

r=me

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 8448148 [details] [diff] [review]
Patch

Review of attachment 8448148 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +7257,5 @@
>  
>  void
>  nsGlobalWindow::ClearTimeout(int32_t aHandle, ErrorResult& aError)
>  {
> +  FORWARD_TO_INNER_OR_THROW(ClearTimeout, (aHandle, aError), aError, );

Shouldn't we be doing this in the XPCOM version of this function? Who else would call this with an outer?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think the XPCOM versions might be dead.

Comment 4

[Peter Van der Beken [:peterv]]

Then why isn't that just asserting instead of forwarding? Again, who would call this with an outer?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can we assume that every WebIDL entry point on Window is only called on an inner?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

From the bindings, anyways.  Obviously nothing stops someone else from calling the C++ function manually.

Comment 7

[Boris Zbarsky [:bzbarsky]]

From the bindings, yes, you can.