1032364 - Change gralloc buffer's key to 64bit

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1031527 +++

Comment 1

[Sotaro Ikeda [:sotaro]]

This bug is created based on bug 1031527 Comment 7.

As a gralloc buffer's key, "int" is used. 32 bit is too small for it. We should change it to 64bit.

Comment 2

[Sotaro Ikeda [:sotaro]]

Nominate to "b2g-v2.0+". This bug blocks b2g-v2.0+ bug.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Change gralloc buffer's key to 64bit

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> Created attachment 8448213 [details] [diff] [review]
> patch - Change gralloc buffer's key to 64bit

It removes atomic from SharedBufferManagerParent::sBufferKey. gecko does not support 64bit atomic now. sBufferKey is used only in SharedBufferManagerParent::RecvAllocateGrallocBuffer(). Therefore Atomic is not necessary for the sBufferKey.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Change gralloc buffer's key to 64bit

Un-bitrot. Carry "r=jmuizelaar".

Comment 6

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=c0e8721b45cb

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Sotaro may have already asked to test with this patch, but doing it in the bug just so that others can tell.

Comment 8

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/312fd139c63e

Comment 9

[Inder]

(In reply to Milan Sreckovic [:milan] from comment #7)
> Sotaro may have already asked to test with this patch, but doing it in the
> bug just so that others can tell.
It doesn't apply cleanly on 2.0. Can you please provide an updated patch.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/312fd139c63e

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 for b2gv2.0 - Change gralloc buffer's key to 64bit

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Inder from comment #9)
> (In reply to Milan Sreckovic [:milan] from comment #7)
> > Sotaro may have already asked to test with this patch, but doing it in the
> > bug just so that others can tell.
> It doesn't apply cleanly on 2.0. Can you please provide an updated patch.

Created a patch attachment 8450186 [details] [diff] [review] for b2g v2.0.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9886da8086bc

Comment 14

[Brogan Zumwalt [Inactive]]

No steps available to perform verification. Unable to verify bug.

Comment 15

[Brogan Zumwalt [Inactive]]

Correction: Cannot perform verification due to automation steps in original bug of this cloned bug.