Change gralloc buffer's key to 64bit

RESOLVED FIXED in Firefox 32, Firefox OS v2.0

Status

()

Core
Graphics: Layers
P1
blocker
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

32 Branch
mozilla33
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-b2g:2.0+, firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1031527 +++
(Assignee)

Comment 1

3 years ago
This bug is created based on bug 1031527 Comment 7.

As a gralloc buffer's key, "int" is used. 32 bit is too small for it. We should change it to 64bit.
(Assignee)

Updated

3 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 2

3 years ago
Nominate to "b2g-v2.0+". This bug blocks b2g-v2.0+ bug.
blocking-b2g: --- → 2.0?
(Assignee)

Comment 3

3 years ago
Created attachment 8448213 [details] [diff] [review]
patch - Change gralloc buffer's key to 64bit
(Assignee)

Comment 4

3 years ago
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> Created attachment 8448213 [details] [diff] [review]
> patch - Change gralloc buffer's key to 64bit

It removes atomic from SharedBufferManagerParent::sBufferKey. gecko does not support 64bit atomic now. sBufferKey is used only in SharedBufferManagerParent::RecvAllocateGrallocBuffer(). Therefore Atomic is not necessary for the sBufferKey.
(Assignee)

Updated

3 years ago
Attachment #8448213 - Flags: review?(jmuizelaar)

Updated

3 years ago
blocking-b2g: 2.0? → 2.0+
Attachment #8448213 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8449487 [details] [diff] [review]
patch v2 - Change gralloc buffer's key to 64bit

Un-bitrot. Carry "r=jmuizelaar".
Attachment #8448213 - Attachment is obsolete: true
Attachment #8449487 - Flags: review+
(Assignee)

Comment 6

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=c0e8721b45cb
Sotaro may have already asked to test with this patch, but doing it in the bug just so that others can tell.
Flags: needinfo?(mvines)
Flags: needinfo?(mvines) → needinfo?(ikumar)
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/312fd139c63e

Comment 9

3 years ago
(In reply to Milan Sreckovic [:milan] from comment #7)
> Sotaro may have already asked to test with this patch, but doing it in the
> bug just so that others can tell.
It doesn't apply cleanly on 2.0. Can you please provide an updated patch.
Flags: needinfo?(ikumar)
https://hg.mozilla.org/mozilla-central/rev/312fd139c63e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(Assignee)

Comment 11

3 years ago
Created attachment 8450186 [details] [diff] [review]
patch v2 for b2gv2.0 - Change gralloc buffer's key to 64bit
(Assignee)

Comment 12

3 years ago
(In reply to Inder from comment #9)
> (In reply to Milan Sreckovic [:milan] from comment #7)
> > Sotaro may have already asked to test with this patch, but doing it in the
> > bug just so that others can tell.
> It doesn't apply cleanly on 2.0. Can you please provide an updated patch.

Created a patch attachment 8450186 [details] [diff] [review] for b2g v2.0.
https://hg.mozilla.org/releases/mozilla-aurora/rev/9886da8086bc
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
status-firefox31: --- → wontfix
status-firefox32: --- → fixed
status-firefox33: --- → fixed
No steps available to perform verification. Unable to verify bug.
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
Correction: Cannot perform verification due to automation steps in original bug of this cloned bug.
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage+][QAnalyst-verify-]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.