Closed Bug 1032364 Opened 5 years ago Closed 5 years ago

Change gralloc buffer's key to 64bit

Categories

(Core :: Graphics: Layers, defect, P1, blocker)

32 Branch
ARM
Gonk (Firefox OS)
defect

Tracking

()

RESOLVED FIXED
mozilla33
blocking-b2g 2.0+
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1031527 +++
This bug is created based on bug 1031527 Comment 7.

As a gralloc buffer's key, "int" is used. 32 bit is too small for it. We should change it to 64bit.
Assignee: nobody → sotaro.ikeda.g
Nominate to "b2g-v2.0+". This bug blocks b2g-v2.0+ bug.
blocking-b2g: --- → 2.0?
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> Created attachment 8448213 [details] [diff] [review]
> patch - Change gralloc buffer's key to 64bit

It removes atomic from SharedBufferManagerParent::sBufferKey. gecko does not support 64bit atomic now. sBufferKey is used only in SharedBufferManagerParent::RecvAllocateGrallocBuffer(). Therefore Atomic is not necessary for the sBufferKey.
Attachment #8448213 - Flags: review?(jmuizelaar)
blocking-b2g: 2.0? → 2.0+
Attachment #8448213 - Flags: review?(jmuizelaar) → review+
Un-bitrot. Carry "r=jmuizelaar".
Attachment #8448213 - Attachment is obsolete: true
Attachment #8449487 - Flags: review+
Sotaro may have already asked to test with this patch, but doing it in the bug just so that others can tell.
Flags: needinfo?(mvines)
Flags: needinfo?(mvines) → needinfo?(ikumar)
(In reply to Milan Sreckovic [:milan] from comment #7)
> Sotaro may have already asked to test with this patch, but doing it in the
> bug just so that others can tell.
It doesn't apply cleanly on 2.0. Can you please provide an updated patch.
Flags: needinfo?(ikumar)
https://hg.mozilla.org/mozilla-central/rev/312fd139c63e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(In reply to Inder from comment #9)
> (In reply to Milan Sreckovic [:milan] from comment #7)
> > Sotaro may have already asked to test with this patch, but doing it in the
> > bug just so that others can tell.
> It doesn't apply cleanly on 2.0. Can you please provide an updated patch.

Created a patch attachment 8450186 [details] [diff] [review] for b2g v2.0.
No steps available to perform verification. Unable to verify bug.
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-]
Flags: needinfo?(ktucker)
Correction: Cannot perform verification due to automation steps in original bug of this cloned bug.
QA Whiteboard: [QAnalyst-Triage?][QAnalyst-verify-] → [QAnalyst-Triage+][QAnalyst-verify-]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.