1032417 - nsPluginElement destructor defined in header file causes compile error

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jon Morton [:jmorton]]

nsPluginElement's destructor is defined directly in the header class declaration, which causes compile errors if it can't see the nsMimeType header, which it doesn't explicitly include:

Compile error: http://pastebin.com/raw.php?i=LEcZLLt5

Currently on m-c the unified binding includes are grouped in such a way that masks this error, but changes that cause nsPluginElement.h to be included before something that can see nsMimeType surfaces the error.

Comment 1

[Jon Morton [:jmorton]]

Attachment: Bug-1032417-Move-nsPluginElement-Destructor.patch

This should fix the error by moving the offending destructor to the implementation file.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8448240 [details] [diff] [review]
Bug-1032417-Move-nsPluginElement-Destructor.patch

Review of attachment 8448240 [details] [diff] [review]:
-----------------------------------------------------------------

Do you want to rebase this to remove the include added in https://hg.mozilla.org/integration/mozilla-inbound/rev/510cb3e9dcdb ?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

btw you defined a ctor out of line, not a dtor ...

Comment 4

[Jon Morton [:jmorton]]

Attachment: Bug-1032417-Move-nsPluginElement-Destructor.patch

Rebase and fix unforgivable stupidity

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/231c5bbd4a75

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/231c5bbd4a75